Skip to content

Revert ios build workaround for Firebase packages #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Revert ios build workaround for Firebase packages #1388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ios/Flutter/Zulip.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,2 @@
// Configuration settings file format documentation can be found at:
// https://help.apple.com/xcode/#/dev745c5c974

// TODO(firebase/flutterfire#13323): remove this flag
//
// This flag is added to work around the iOS build failing
// on Xcode 16. Remove it when `package:firebase_messaging`
// is patched with a fix to build successfully on Xcode 16:
// https://github.com/firebase/flutterfire/issues/13323
CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES=YES