Skip to content

Fixes: Fix notification delay in the android when app is not running in background #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Itsamanjain
Copy link

@Itsamanjain Itsamanjain commented Jan 9, 2024

Fix: #342
fixes notification delay when app is not running in the background

…in background

Fix: #342
fixes notification delay when app is not running in the backend
@Itsamanjain
Copy link
Author

Moving forward, need to focus on the notification sound. It currently works on Zulip web, but need to ensure it functions correctly in Zulip Flutter as well. The associated file, named 'zulip.mp3,' is already present in Zulip mobile.

@gnprice
Copy link
Member

gnprice commented Jan 9, 2024

Thanks.

What did you do to test that this change successfully fixes #342? That's the main work to be done here.

The notification sound seems unrelated to this PR's change, so let's keep the PR thread focused on the PR. There's an existing issue for playing Zulip's custom sound, but it should already be the case that we play the system default sound. If you're able to reproduce the issue reported at #342 (comment) where that doesn't happen, please start a new thread and include details about how you reproduce it and what you observe.

@Itsamanjain
Copy link
Author

Itsamanjain commented Jan 10, 2024

@gnprice , please check these changes. I sent a direct message to myself from another ID. Also, try it in the test section of chat.zulip.org. I noticed notifications are coming instantly even when the app is not running in the background.
So, it works well even if app is not running in background.
IMG_20240110_102129

@Itsamanjain
Copy link
Author

Itsamanjain commented Jan 10, 2024

Here is test result in test section of chat.zulip.org notification

@Itsamanjain Itsamanjain closed this by deleting the head repository Jan 10, 2024
@Itsamanjain
Copy link
Author

closed it by mistake. I will create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications delayed when app not running, on Android
2 participants