fixes: Fix Notification delay when app is not running in background #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gnprice PR Is ready to merge. |
|
The original issue #342 doesn't always reproduce, so it's already the case in main that you'll sometimes get notifications promptly after putting the app in the background. To effectively test that something fixes that issue, what's needed is to find a pattern that reliably reproduces the issue, then try that after the fix and find that it no longer reproduces. |
|
I tried this change myself, and it didn't fix the issue. I'll put details in the issue thread #342. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #342
This PR is created after #482 . It was closed by mistake, so I created this. I tried DMing myself and also checked it in the "Test Here" section of chat.zulip.org. Now, I'm getting notifications on time even after the app is not running in the background. The test results are in the thread of #482 .