added connecting snackbar and snackbar.dart file #584
Conversation
| ], | ||
| ]; | ||
| }); | ||
| child: Builder(builder: (context) { |
There was a problem hiding this comment.
Update your code editors spacing to match the repo configuration. check the ReadMe File
| @@ -24,8 +24,8 @@ environment: | |||
| # that by the time we want to release, these will have become stable. | |||
| # TODO: Before general release, switch to stable Flutter and Dart versions, | |||
| # or pin exact versions: https://github.com/zulip/zulip-flutter/issues/15 | |||
| sdk: '>=3.4.0-256.0.dev <4.0.0' | |||
| flutter: '>=3.21.0-12.0.pre.26' | |||
| sdk: '>=3.4.0-140.0.dev <4.0.0' | |||
There was a problem hiding this comment.
Never change the sdk version in pubspec.yaml as it is configured for the whole team. refer to ReadMe
| @@ -38,6 +38,7 @@ dependencies: | |||
| sdk: flutter | |||
| flutter_localizations: | |||
| sdk: flutter | |||
| fluttertoast: ^8.2.4 | |||
There was a problem hiding this comment.
As mentioned by @gnprice in the stream no need to use fluttertoast
|
Nice work but it can be improved, according to the commits discipline your commits need some restructure. |
|
thankyou @Khader-1 for your feedback . appreciated your inputs and i will definetly work on it |
|
Thanks @Khader-1 for the initial review! And thanks @satyam372 for the contribution. For cross-reference: it looks like this started as #583 and then became #586. @satyam372 For future pull requests, it's better to update the existing PR than to close it and open a new one. See https://zulip.readthedocs.io/en/latest/git/pull-requests.html#update-a-pull-request . |
Added 'snackbar.dart' file to show the snackbar. I have created this file inside widget folder and then imported it in app.dart and message_list.dart file .
working : I have used "connectivity_plus: ^5.0.2" package to implement this. This package allows developers to see the connectivity of device . This helps us to determine whether our device has active internet connection or not .
Video link:-
https://github.com/zulip/zulip-flutter/assets/112092492/911a49a4-568c-4b29-82bc-1c8d0bf5872b