Skip to content

#465_connecting_banner #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

#465_connecting_banner #586

wants to merge 2 commits into from

Conversation

satyam372
Copy link

video link:-

snackbar_3.mp4

To implement this feature i have used connectivity-plus package "connectivity_plus: ^5.0.2" . This package is used to see if the device has an active internet connection or not .
I have written code for snackbar in "snackbar.dart" file and then included it in app.dart file and message_list.dart file.
The snackbart.dart file is created inside the widget folder
Through this feature we can give the status of connectivity to the user.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of your code has been auto-formatted and this project doesn't use auto-formatting, so I think you should check that. If your editor or IDE automatically reformats the existing code, you'll want to turn that off.

@abelaba
Copy link
Contributor

abelaba commented Mar 24, 2024

You need to also add tests for the new snack bar widget you have added.

https://github.com/zulip/zulip-flutter?tab=readme-ov-file#writing-tests

@abelaba
Copy link
Contributor

abelaba commented Mar 24, 2024

@gnprice
Copy link
Member

gnprice commented Mar 25, 2024

Thanks @abelaba for the initial review! Those are all good comments.

@satyam372 In fact those are exactly the things that will be needed before we can review this PR in detail. (Plus one more thing: the tests will need to be passing.) For background, see: https://github.com/zulip/zulip-flutter#submitting-a-pull-request

@satyam372
Copy link
Author

Thankyou @gnprice and @abelaba for your feedback . I have started working on it and will make a good PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants