Skip to content

Update upstream #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Nov 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
e005d5f
Fix name of launch option in docs (#8113)
ILikeToHelp Oct 28, 2019
6c3fa81
Use same interpreter as used by jupyter when checking pandas (#8228)
DonJayamanne Oct 28, 2019
6046f83
Make sure when typing in an edit box, the notebook editor scrolls (#8…
rchiodo Oct 28, 2019
24dd883
Fix monaco editor style differences between insiders and shipping (#8…
rchiodo Oct 28, 2019
306f5dc
Add '$$' at the beginning and end of empty latex equations to have th…
Oct 28, 2019
e77018a
Minimize GPU usage for interactive and notebook editor (#8268)
rchiodo Oct 28, 2019
30862ad
Re-Enable ability to use built in debugger for DS (#8258)
DonJayamanne Oct 29, 2019
78d1b4a
Support cmd+s on macs for native editor (#8226)
DonJayamanne Oct 29, 2019
4531869
Fix waitForMessage timeouts on the functional tests (#8278)
rchiodo Oct 29, 2019
b5a9ca2
Fix change directory command for native editor export (#8269)
IanMatthewHuff Oct 29, 2019
0d47bcc
Fix gulp install python libs commands with python (#8282)
kimadeline Oct 29, 2019
cd56738
Fix a number of issues related to opening new notebooks (#8270)
rchiodo Oct 29, 2019
7a6fc83
removed max-width from .controls-div to give it the space it need wit…
Oct 29, 2019
782c774
Directly link to Stack Overflow
brettcannon Oct 29, 2019
5bcc7de
Stop using an issue template to direct people to Stack Overflow
brettcannon Oct 29, 2019
8f26b2e
Ensure ctrl+s is not supported on Mac for Notebooks (#8283)
DonJayamanne Oct 30, 2019
abcea5a
removed extra space at the left of the native editor (#8288)
Oct 30, 2019
d17206c
Use Python 3.7.5 in CI (#8297)
kimadeline Oct 30, 2019
7418b74
added telemetry to the errorHandler when jupyter (#8305)
Oct 30, 2019
788d9d9
Enhance "select a workspace" message when selecting interpreter (#8299)
Oct 31, 2019
fa9c62c
Fix Language Server download typo (#8313)
luabud Oct 31, 2019
796f843
add command translation for turkish (#8292)
alioguzhan Oct 31, 2019
19f64ea
Changing NewDebugAdapter experiment to be on for 50% of insiders user…
luabud Oct 31, 2019
81a2af6
Adds logging support for python debug adapter (#8272)
karthiknadig Oct 31, 2019
0aedf6d
Ensure data science debugger works with the shipped version of PTVSD …
DonJayamanne Oct 31, 2019
0774fb8
Cache the promise returned by the command finder (#8317)
DonJayamanne Oct 31, 2019
2339983
clear execution count of all cells when user presses 'Clear All Outpu…
Oct 31, 2019
e713994
fix text/html to concat (#8328)
IanMatthewHuff Oct 31, 2019
9e7bce4
Adjust line number styles to line up with VSCode (#8322)
DonJayamanne Oct 31, 2019
9382959
Never update cell contents from the extension side (#8325)
rchiodo Nov 1, 2019
1fdf69a
Disable tracking of performance of class instantiation (#8330)
DonJayamanne Nov 1, 2019
072ccea
Refactor classes in prep for perf improvements (#8319)
DonJayamanne Nov 1, 2019
f4c4896
outputs will appear as a single textbox, with one scrollbar (#8327)
Nov 1, 2019
c50c778
Moved the toolbar to render right below inputs. (#8336)
Nov 1, 2019
7c6bede
Prompt to open exported notebook in native editor (#8315)
DonJayamanne Nov 1, 2019
47b19d0
Fixed plots by adding extra check in transformOutput (#8343)
Nov 1, 2019
eeba4cb
Add unit tests for common/process/pythonProcess.ts (#8329)
kimadeline Nov 4, 2019
b202ad2
Use the new debug adapter with DS if both experiments are enabled (#8…
DonJayamanne Nov 4, 2019
61a6282
Use PythonExecutionService when possible (#8338)
karthiknadig Nov 4, 2019
ed07ffc
simplify remote URI specification and clear up wording (#8367)
IanMatthewHuff Nov 4, 2019
700bc48
Track if jupyter is not installed in current env (#8370)
DonJayamanne Nov 4, 2019
58a6e24
Update gather functionality to support 0.4.1 of python-program-analys…
greazer Nov 5, 2019
ef6d780
Improvements to startup of notebook (#8332)
DonJayamanne Nov 5, 2019
5489cf1
Gathered nb's from py don't show original file. (#8374)
greazer Nov 5, 2019
a139d63
Update Test Explorer icons to match new VS Code icons (#8360)
luabud Nov 5, 2019
ea0dc14
Correctly handle interpreter changes for Interactive and Notebook (#8…
IanMatthewHuff Nov 5, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .github/ISSUE_TEMPLATE/5_question.md

This file was deleted.

5 changes: 5 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
blank_issues_enabled: true
contact_links:
- name: Stack Overflow
url: https://stackoverflow.com/questions/tagged/visual-studio-code+python
about: Please ask questions here.
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ TypeScript errors and warnings will be displayed in the `Problems` window of Vis
### Validate your changes

To test the changes you launch a development version of VS Code on the workspace vscode, which you are currently editing.
Use the `Launch Extension` launch option.
Use the `Extension` launch option.

### Debugging Unit Tests

Expand Down Expand Up @@ -147,7 +147,7 @@ To run only the functional tests:

### Standard Debugging

Clone the repo into any directory, open that directory in VSCode, and use the `Launch Extension` launch option within VSCode.
Clone the repo into any directory, open that directory in VSCode, and use the `Extension` launch option within VSCode.

### Debugging the Python Extension Debugger

Expand Down
4 changes: 2 additions & 2 deletions build/.mocha.unittests.ts.opts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
--require ts-node/register
--require out/test/unittests.js
--require src/test/unittests.ts
--reporter mocha-multi-reporters
--reporter-options configFile=build/.mocha-multi-reporters.config
--ui tdd
--recursive
--colors
./src/test/**/*.unit.test.ts
./src/test/**/*.unit.test.ts
2 changes: 1 addition & 1 deletion build/ci/postInstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ var constants_1 = require("../constants");
* The solution is to modify the type definition file after `npm install`.
*/
function fixJupyterLabDTSFiles() {
var relativePath = path.join('node_modules', '@jupyterlab', 'coreutils', 'lib', 'settingregistry.d.ts');
var relativePath = path.join('node_modules', '@jupyterlab', 'services', 'node_modules', '@jupyterlab', 'coreutils', 'lib', 'settingregistry.d.ts');
var filePath = path.join(constants_1.ExtensionRootDir, relativePath);
if (!fs.existsSync(filePath)) {
throw new Error("Type Definition file from JupyterLab not found '" + filePath + "' (pvsc post install script)");
Expand Down
2 changes: 1 addition & 1 deletion build/ci/templates/globals.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
variables:
PythonVersion: '3.7.4' # Always use latest version.
PythonVersion: '3.7' # Always use latest version.
NodeVersion: '10.11.0' # Check version of node used in VS Code.
NpmVersion: '6.10.3'
MOCHA_FILE: '$(Build.ArtifactStagingDirectory)/test-junit.xml' # All test files will write their JUnit xml output to this file, clobbering the last time it was written.
Expand Down
2 changes: 1 addition & 1 deletion build/ci/templates/jobs/uitest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ parameters:
# All scenarios tagged with `@noNeedToTestInAllPython`, will run in the latest version of Python.
# When using other versions of Python, ignore `@noNeedToTestInAllPython`.
{
"version": "3.7.4",
"version": "3.7",
"displayName": "37",
"excludeTags": "not @python3.6 and not @python3.5 and not @python2"
},
Expand Down
10 changes: 5 additions & 5 deletions experiments.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@
"max": 20
},
{
"name": "DebugAdapterFactory - control",
"name": "DebugAdapterFactoryInsiders - control",
"salt": "DebugAdapterFactory",
"min": 0,
"max": 0
"max": 50
},
{
"name": "DebugAdapterFactory - experiment",
"name": "DebugAdapterFactoryInsiders - experiment",
"salt": "DebugAdapterFactory",
"min": 0,
"max": 0
"min": 50,
"max": 100
},
{
"name": "PtvsdWheels37 - control",
Expand Down
4 changes: 2 additions & 2 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ gulp.task('installPtvsdWheels', async () => {
});
if (!success) {
console.info("Failed to install new PTVSD wheels using 'python3', attempting to install using 'python'");
await spawnAsync('python', args.concat(requirement)).catch(ex => console.error("Failed to install PTVSD 5.0 wheels using 'python'", ex));
await spawnAsync('python', args).catch(ex => console.error("Failed to install PTVSD 5.0 wheels using 'python'", ex));
}
});

Expand All @@ -283,7 +283,7 @@ gulp.task('installOldPtvsd', async () => {
});
if (!success) {
console.info("Failed to install PTVSD using 'python3', attempting to install using 'python'");
await spawnAsync('python', args.concat(requirement)).catch(ex => console.error("Failed to install PTVSD using 'python'", ex));
await spawnAsync('python', args).catch(ex => console.error("Failed to install PTVSD using 'python'", ex));
}
});

Expand Down
1 change: 1 addition & 0 deletions news/1 Enhancements/8078.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Prompt to open exported `Notebook` in the `Notebook Editor`.
2 changes: 2 additions & 0 deletions news/1 Enhancements/8103.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Enhance "select a workspace" message when selecting interpreter
(thanks [Nikolay Kondratyev](https://github.com/kondratyev-nv/))
1 change: 1 addition & 0 deletions news/1 Enhancements/8106.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add logging support for python debug adapter.
1 change: 1 addition & 0 deletions news/1 Enhancements/8289.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Style adjustments to line numbers (color and width) in the `Native Editor`, to line up with VS Code styles.
2 changes: 2 additions & 0 deletions news/1 Enhancements/8320.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Added command translations for Turkish.
(thanks to [alioguzhan](https://github.com/alioguzhan/))
1 change: 1 addition & 0 deletions news/2 Fixes/7567.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
When exporting a notebook editor to python script don't use the temp file location for generating the export.
1 change: 1 addition & 0 deletions news/2 Fixes/7853.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
'Clear All Output' now deletes execution count for all cells.
1 change: 1 addition & 0 deletions news/2 Fixes/7873.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix strings of commas appearing in text/html output in the notebook editor.
1 change: 1 addition & 0 deletions news/2 Fixes/7980.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
When creating a new blank notebook, it has existing text in it already.
1 change: 1 addition & 0 deletions news/2 Fixes/7992.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Can now include a LaTeX-style equation without surrounding the equation with '$' in a markdown cell.
1 change: 1 addition & 0 deletions news/2 Fixes/8003.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make a spinner appear during executing a cell.
1 change: 1 addition & 0 deletions news/2 Fixes/8006.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Signature help is overflowing out of the signature help widget on the Notebook Editor.
1 change: 1 addition & 0 deletions news/2 Fixes/8019.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Correctly restart jupyter sessions when the active interpreter is changed.
1 change: 1 addition & 0 deletions news/2 Fixes/8021.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Clear up wording around jupyterServerURI and remove the quick pick from the flow of setting that.
1 change: 1 addition & 0 deletions news/2 Fixes/8039.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Minimize the GPU impact of the interactive window and the notebook editor.
1 change: 1 addition & 0 deletions news/2 Fixes/8084.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
When checking the version of `pandas`, use the same interpreter used to start `Jupyter`.
1 change: 1 addition & 0 deletions news/2 Fixes/8132.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cannot create more than one blank notebook.
1 change: 1 addition & 0 deletions news/2 Fixes/8151.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Support `⌘+s` keyboard shortcut for saving `Notebooks`.
1 change: 1 addition & 0 deletions news/2 Fixes/8205.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Scroll the notebook editor when giving focus or changing line of a code cell.
1 change: 1 addition & 0 deletions news/2 Fixes/8215.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Prevent code from changing in the Notebook Editor while running a cell.
1 change: 1 addition & 0 deletions news/2 Fixes/8263.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
When updating the Python extension, unsaved changes to notebooks are lost.
1 change: 1 addition & 0 deletions news/2 Fixes/8296.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix CI to use Python 3.7.5.
1 change: 1 addition & 0 deletions news/3 Code Health/6065.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add unit tests for src/client/common/process/pythonProcess.ts.
1 change: 1 addition & 0 deletions news/3 Code Health/7809.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update Test Explorer icons to match new VS Code icons
1 change: 1 addition & 0 deletions news/3 Code Health/8255.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Timeout with new waitForMessage in native editor tests.
1 change: 1 addition & 0 deletions news/3 Code Health/8280.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove code used to track perf of creation classes.
Loading