Skip to content

Update upstream #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Nov 6, 2019
Merged

Update upstream #1

merged 46 commits into from
Nov 6, 2019

Conversation

zztalker
Copy link
Owner

@zztalker zztalker commented Nov 6, 2019

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

ILikeToHelp and others added 30 commits October 28, 2019 08:19
This launch option was renamed to "Extension" in be2ae45.
)

* Fix scrolling while typing

* Fix linting error

* Fix column to stay the same as moving through cells

* Add news entry
)

* Fix monaco editor style differences between insiders and shipping

* Fix linter
…em render correctly (#8213)

* Add '$$' at the beginning and end of empty latex
 equations to have them render correctly.

* Moved changes to its own file.
Started using Regular Expressions instead of indexOf
Added unit tests

* added missing copyright

* Made the 2 regex expressions a bit more specific,
it now includes the opening anc closing brackets,
with whatever name the user chooses.

Also, the code will run only if the amount of indexes are the same.

* changed the way the function is exported.
* Minimize usage of the GPU and fix the execution count spinner

* Add news entries
* Support cmd+s on macs for native editor
* Code review fixes
* Fixes to tests
* Up timeout value for messages

* Remove the 'loading' test. Don't really need this and its hard to get exact

* Up the timeout again

* Make run button more definite

* Add news entry
* Fix creating multiple new notebooks
Fix opening unsaved notebooks after extension update
Fix creating new notebooks to be empty

* Add news entries

* Review feedback - fix algorithm to clear workspace data

* Fix test failure

* Update to use real path in tests
…h bigger font sizes (#8281)

* removed max-width from .controls-div
to give it the space it need with bigger font sizes

* added padding to the right of .controls-div

* adjusted padding on .controls-div
* removed extra space at the left of the native
editor

* changed the border to margin

* changed python version to match the one in azure
* Use Python 3.7.5
* Don't specify minor version
* Enhance "select a workspace" message when selecting interpreter for multi-root workspace
* Add news entry
* add command translation for turkish
* add news entry file
refers to #8320
#8267)

* Changing NewDebugAdapter experiment to be on for 50% of insiders users

* Fix wrong rename of DebugAdapterDescriptorFactory enum

* Revert changes for Debug Adapter tests
* Add debug session logging via tracker
* Add log messages
* Ensure we only log as needed.
* Change log file name
* Add news item
* Adding unit test for debug session logger
* Improve coverage.
* Address review comments.
…8312)

* Use experimental debugger or old.
* Simple fix to disable experiments in DS tests
* Fix crlf
* Cache the promise
* Fix broken test
…t' (#8318)

* clear execution count of all cells when user
presses 'Clear All Output'

* remove execution count with immutable
* Adjust line number styles to line up with VSCode
* Address code review comments
DonJayamanne and others added 16 commits November 1, 2019 09:23
* Remove code used to track perf of class creation
* News
* Address linter issue
* Refactor classes in prep for perf improvements
* Fix linter issues
* made all outputs a single jsx element

* fixed a bug, error with mimetype would show
every time

* removed 1 useless line

* removed useless comment
This saves a bit of space with single line block of code.
* Prompt to open exported nb in editor
* News entry file
* Fix tests
* Fixes to how tests are run
* Fixed plots by adding extra check in
transformOutput.

Also added the prop key to some outputs
to avoid errors in the console.

* Used bind instead of checking if 'this' exists
* Add unit tests for common/process/pythonProcess
* Adjust test titles
* getExecutablePath and isModuleInstalled tests
* exec* tests
* Lol update suite name
* Fix tests
* Add unit test for truncated versionInfo
* Update symbol provider.
* Update code execution helper.
* Switch to typemoq
* Fix for typemoq and ts-mockito limitations
* Fix helper tests
* Clean up symbol navigator tests
* Address comments.
* Track if jupyter is not installed in current env
* Use global store
* Address code review comments
…is (#8219)

* Main changes for update

* Gather working (using 0.4.1 of python analysis)

* Prep for PR

* Implement gather for native editor (first pass)

* Fix cell rangification

* Cleanup

* Fix error

* Support knowng cell has been exec'd

* Bug fix and show gathered notebook

* Make strings localizable

* executedInCurrentKernal => executeKernalId

* Add ConnectedToNotebook

* Simplify logic to make use of cellVM

* Attempt to fix multi-nb gather (failed)

* Support separate notebook gathers

* PR adjustments

* More PR updates

* More PR updates

* cleanup

* Yet another PR update

* Fixups

* Default gather support to true

* Update

* Gather cleaned up and working

* String updates

* Update strings, make gatherToScript

* fix compile errors (why don't I see these?)

* Fix executionslicer

* Fix unit test

* Fix use of gather

* Fix most of the unit tests

* Disabling failing tests (for now)

* Fix remaining Unit Tests

* Fix functional tests

* Show file in gathered nb

* Add a note about gather being conservative.

* Don't use the ICell.file property to get nb name

* Remove unecessary gather APIs

* Put back old algorithm for generating code lenses

* Fixup type

* Gather doesn't work on markdown

* Turn off gather in markdown for interactive too
* Parallelize
* Fix tests
* Fix typo
* Fixed order of arguments to ensure tests pass
* Linter issues
* Update icons from vscode-icon repo
* Update custom icons with latest version
* Update icons with latest version
* Add new run all tests icon
* Add news files
@zztalker zztalker merged commit fcaa584 into zztalker:master Nov 6, 2019
zztalker pushed a commit that referenced this pull request May 13, 2020
* Update .npmrc to get latest python

* Update to latest analysis and fix gather icon

* Use sliceLastExecution and fix
cell executionId for gather.

* Fix import of python analysis

* Update to python-analysis 0.4.12

* get gathered text from cell.textSlice

* Updates to fix gather logging

* All updates to using new nb owned gather.

* Working cell execution count codelenses.

* Rename gather* to match existing classes
and interfaces

* Update to latest python analysis

* lock python analysis ver

* Fix MockJupyterNotebook

* Fix casing of getgatherProvider

* Private Gather support #1
Dynamically look for python-program-analysis. If not there
gather is unsupported.

* Ensure cellHashProvider can be found

* Revert back to uri for NBExecutionActivated

* Update new jupyterServerWrapper

* Workaround fix for screwed up cellhashes
Being fixed by Ian in a separate branch.

* Gracefully fail if python-pgm-analysis is absent

* Resolve obvious unit test problems.

* Fixes to make sure that gather.ts is loadable.

* Optional gather build, editing, running works.

* Remove unecessary getAll of IGatherProviders.

* Code cleanup

* Fix gather notebook header
- Also remove reference to python-program-analysis in package.json

* Gather icon not only on hover

* Enable gather only in insiders

* Init gather only if enabled.

* Add link to survey

* Fix spacing in initialization.yml

* Make linter and prettier happy

* Make webpack happy with regard to gather

* Don't define ENABLE_GATHER env var

* Couple minor issues found in test

* Fix a few tests

* Everything but dataScienceIocContainer.ts

* More fixes

* Whoops, fix IW functional test back to original

* Temporarily include datascienceioccontainer in 120
character line length.

* Make linter finally happy.

* Fix Gather functional tests

* A bit more cleanup

* React to PR feedback

* Couple more PR review changes.

* Tweak

* More minor cleanup

* Fix provider finders.

* Actually fix the provider get problem.

* Fix smoke test

* Fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.