Update Request Types #2512
Merged
Update Request Types #2512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
msal-browser
…tion-library-for-js into update-request-types
tnorling
requested review from
hectormmg,
jasonnutter,
jmckennon,
pkanher617 and
sameerag
as code owners
tnorling
modified the milestones:
@azure/[email protected] Release,
@azure/[email protected]
…tion-library-for-js into update-request-types
3 tasks
sameerag
reviewed
Nov 13, 2020
change/@azure-msal-browser-2020-11-06-14-12-06-update-request-types.json
Show resolved
Hide resolved
jasonnutter
reviewed
Nov 13, 2020
jasonnutter
reviewed
Nov 13, 2020
change/@azure-msal-common-2020-11-06-14-12-06-update-request-types.json
Outdated
Show resolved
Hide resolved
…ypes.json Co-authored-by: Jason Nutter <[email protected]>
…tion-library-for-js into update-request-types
pkanher617
reviewed
Nov 16, 2020
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "type": "major", | |||
There was a problem hiding this comment.
Are we ok with doing [email protected] right now?
pkanher617
approved these changes
Nov 16, 2020
10 tasks
mkArtakMSFT
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Jan 13, 2021
#### Description This PR updates the version of the MSAL.js dependency that we redistribute in our Authentication.Msal library in response to user requests and recommendation from the MSAL team. #### Technical Description This PR contains some code changes in response to some changes in type definition over in MSAL.js: - AzureAD/microsoft-authentication-library-for-js#2105 - AzureAD/microsoft-authentication-library-for-js#2512 #### Customer Impact Without these changes, if users want to pick up required bug fixes in the downstream MSAL.js library, they would have to compile their own version of JavaScript dependencies and integrate them into their project. This PR allows users to consume bug fixes blocking customer login and platform support without having to put in difficult workarounds. #### Regression? - [ ] Yes - [X] No #### Risk - [ ] High - [ ] Medium - [X] Low Change contains no breaking changes and was made on recommendation of the MSAL team. Manual verification completed. #### Verification - [X] Manual (required) - [ ] Automated Verified navigating to the authorized-only fetch data page, logging in, confirming redirect, logging out, logging in again on: - Azure B2C + Blazor WASM Hosted - Azure B2C + Blazor Standalone - Azure AAD + Blazor WASM Hosted - Azure AAD + Blazor WASM Standalone #### Packaging changes reviewed? - [ ] Yes - [ ] No - [X] N/A Addresses #29010, #28969, #28956
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates request types to separate API surface from the request objects needed internally.