Skip to content

Update msal-browser dependency to latest version #29010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
captainsafia opened this issue Jan 4, 2021 · 0 comments
Closed

Update msal-browser dependency to latest version #29010

captainsafia opened this issue Jan 4, 2021 · 0 comments
Assignees
@captainsafia
Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Milestone
5.0.3

Comments

@captainsafia
Copy link
Member

We're currently shipping the MSAL implementation with msal-browser 2.0.0 which was released about 5 months ago.

The latest version is 2.8.0. We should consider investigating patching to take the latest bits.
@captainsafia captainsafia added the area-blazor Includes: Blazor, Razor Components label Jan 4, 2021
@mkArtakMSFT mkArtakMSFT added this to the 5.0.3 milestone Jan 4, 2021
@mkArtakMSFT mkArtakMSFT added the bug This issue describes a behavior which is not expected - a bug. label Jan 4, 2021
@mkArtakMSFT mkArtakMSFT mentioned this issue Jan 4, 2021
Closed
@juho-hanhimaki juho-hanhimaki mentioned this issue Jan 12, 2021
Closed
@captainsafia captainsafia mentioned this issue Jan 12, 2021
Merged
10 tasks
mkArtakMSFT pushed a commit that referenced this issue Jan 13, 2021
@captainsafia
Update @azure/msal-browser dependency to v2.8.0 (#29226)
50b3190 
#### Description

This PR updates the version of the MSAL.js dependency that we redistribute in our Authentication.Msal library in response to user requests and recommendation from the MSAL team.

#### Technical Description

This PR contains some code changes in response to some changes in type definition over in MSAL.js:

- AzureAD/microsoft-authentication-library-for-js#2105
- AzureAD/microsoft-authentication-library-for-js#2512

#### Customer Impact

Without these changes, if users want to pick up required bug fixes in the downstream MSAL.js library, they would have to compile their own version of JavaScript dependencies and integrate them into their project.

This PR allows users to consume bug fixes blocking customer login and platform support without having to put in difficult workarounds.

#### Regression?
- [ ] Yes
- [X] No

#### Risk
- [ ] High
- [ ] Medium
- [X] Low

Change contains no breaking changes and was made on recommendation of the MSAL team. Manual verification completed.

#### Verification
- [X] Manual (required)
- [ ] Automated

Verified navigating to the authorized-only fetch data page, logging in, confirming redirect, logging out, logging in again on:
- Azure B2C + Blazor WASM Hosted
- Azure B2C + Blazor Standalone
- Azure AAD + Blazor WASM Hosted
- Azure AAD + Blazor WASM Standalone

#### Packaging changes reviewed?
- [ ] Yes
- [ ] No
- [X] N/A

Addresses #29010, #28969, #28956
@ghost ghost added Done This issue has been fixed and removed Working labels Jan 13, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@captainsafia captainsafia

Labels
area-blazor Includes: Blazor, Razor Components bug This issue describes a behavior which is not expected - a bug. Done This issue has been fixed
Projects
None yet
Milestone
5.0.3
Development

No branches or pull requests
2 participants
@captainsafia @mkArtakMSFT