Skip to content

Update @azure/msal-browser dependency to v2.8.0 #29226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Jan 12, 2021

Description

This PR updates the version of the MSAL.js dependency that we redistribute in our Authentication.Msal library in response to user requests and recommendation from the MSAL team.

Technical Description

This PR contains some code changes in response to some changes in type definition over in MSAL.js:

Customer Impact

Without these changes, if users want to pick up required bug fixes in the downstream MSAL.js library, they would have to compile their own version of JavaScript dependencies and integrate them into their project.

This PR allows users to consume bug fixes blocking customer login and platform support without having to put in difficult workarounds.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Change contains no breaking changes and was made on recommendation of the MSAL team. Manual verification completed.

Verification

  • Manual (required)
  • Automated

Verified navigating to the authorized-only fetch data page, logging in, confirming redirect, logging out, logging in again on:

  • Azure B2C + Blazor WASM Hosted
  • Azure B2C + Blazor Standalone
  • Azure AAD + Blazor WASM Hosted
  • Azure AAD + Blazor WASM Standalone

Packaging changes reviewed?

  • Yes
  • No
  • N/A

Addresses #29010, #28969, #28956

@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Jan 12, 2021
@captainsafia captainsafia marked this pull request as ready for review January 12, 2021 22:10
@captainsafia captainsafia requested review from SteveSandersonMS and a team as code owners January 12, 2021 22:10
@captainsafia captainsafia added the ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. label Jan 12, 2021
@mkArtakMSFT mkArtakMSFT added Servicing-consider Shiproom approval is required for the issue and removed ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. labels Jan 12, 2021
@ghost
Copy link

ghost commented Jan 12, 2021

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

@mkArtakMSFT mkArtakMSFT added this to the 5.0.3 milestone Jan 12, 2021
@mkArtakMSFT mkArtakMSFT added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jan 13, 2021
Copy link
Contributor

@mkArtakMSFT mkArtakMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @captainsafia!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants