Skip to content

feat: Bump OpenDAL to 0.24 for better seekable support#847

Merged
waynexia merged 2 commits intoGreptimeTeam:developfrom
Xuanwo:bump-opendal
Jan 9, 2023
Merged

feat: Bump OpenDAL to 0.24 for better seekable support#847
waynexia merged 2 commits intoGreptimeTeam:developfrom
Xuanwo:bump-opendal

Conversation

@Xuanwo
Copy link
Copy Markdown
Contributor

@Xuanwo Xuanwo commented Jan 8, 2023

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR will bump OpenDAL to the latest v0.24 version.

Changes include:

v0.24.2 - 2023-01-08

Changed

Fixed

v0.24.1 - 2023-01-08

Fixed

v0.24.0 - 2023-01-07

Added

Changed

Fixed

v0.23.0 - 2022-12-22

Added

v0.22.6 - 2022-12-20

Added

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo changed the title deps: Bump OpenDAL to 0.24 for better seekable support feat: Bump OpenDAL to 0.24 for better seekable support Jan 8, 2023
@v0y4g3r v0y4g3r self-requested a review January 9, 2023 02:42
@v0y4g3r
Copy link
Copy Markdown
Contributor

v0y4g3r commented Jan 9, 2023

Looks like it breaks some parquet unit test.

Copy link
Copy Markdown
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r requested review from killme2008 and waynexia January 9, 2023 02:56
Copy link
Copy Markdown
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 9, 2023

Codecov Report

Merging #847 (3bc7339) into develop (5b675f5) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #847      +/-   ##
===========================================
- Coverage    86.05%   85.87%   -0.18%     
===========================================
  Files          420      420              
  Lines        54976    54982       +6     
===========================================
- Hits         47307    47215      -92     
- Misses        7669     7767      +98     
Flag Coverage Δ
rust 85.87% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object-store/src/lib.rs 100.00% <ø> (ø)
src/storage/src/sst/parquet.rs 98.91% <100.00%> (+0.02%) ⬆️
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
src/datanode/src/instance.rs 52.63% <0.00%> (-17.37%) ⬇️
tests-integration/src/test_util.rs 86.89% <0.00%> (-12.63%) ⬇️
src/servers/src/error.rs 43.18% <0.00%> (-6.82%) ⬇️
src/frontend/src/table/scan.rs 85.18% <0.00%> (-5.56%) ⬇️
src/servers/src/grpc.rs 89.83% <0.00%> (-3.39%) ⬇️
src/sql/src/parser.rs 79.39% <0.00%> (-2.02%) ⬇️
src/servers/src/opentsdb.rs 96.82% <0.00%> (-1.59%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@waynexia waynexia merged commit 777a318 into GreptimeTeam:develop Jan 9, 2023
@waynexia
Copy link
Copy Markdown
Member

waynexia commented Jan 9, 2023

Thanks @Xuanwo

paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
)

* deps: Bump OpenDAL to 0.24 for better seekable support

Signed-off-by: Xuanwo <github@xuanwo.io>

* fix: test

Signed-off-by: Xuanwo <github@xuanwo.io>
Co-authored-by: Lei, HUANG <mrsatangel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants