refactor: use hyprlock provided $LAYOUT for detecting current keyboard layout
#609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automated PR to promote changes from `dev` to `master`. Please review and test before merging. ## For Testers See [TESTING.md](./TESTING.md) for complete testing instructions. ## Suggested Merge Schedule According to our release policy, this PR is expected to be merged on: **Friday** Testers are encouraged to test the changes before merging. Please note that this schedule may be adjusted based on the needs of the project. ## Commits to be merged: --- * chore Add keybind for game launcher (HyDE-Project#597) (891b181) by ProfShiba * feat (hyde-ipc): Our very own IPC handler! (5c4221f) by kRHYME7 * fix(zsh): Use `.user.zsh` (f1446ab) by kRHYME7 * feat(hyde-config): A Go implementation of the parse.config.py (b6c7bb8) by kRHYME7 * chore Add missing modules to Starship config (HyDE-Project#577) (12d113b) by prime-run * fix: [Bug]: Defer oh-my-zsh loading may not be the best option HyDE-Project#578 (882fef0) by kRHYME7 * chore implement fzf-shell integration for `fish` (HyDE-Project#575) (e750c97) by prime-run * fix(fastfetch): Correct random handler (3cb0434) by kRHYME7 * chore add best fzf aliases ever (HyDE-Project#569) (503711a) by prime-run * fix(zsh): Explicit history integration (55721cb) by kRHYME7 * fixed the link color being same as normal text (HyDE-Project#570) (ca3c158) by amit * fix: [Bug]: Game Launcher isn't showing anything HyDE-Project#447 (96be51a) by kRHYME7 * chore style: discord dcol file changes (HyDE-Project#566) (63a2949) by amit * chore refactor(zsh): cleanup zsh for incoing fzf features (abc1a7b) by prime-run * chore breaking(zsh): move ~/.hyde.zshrc to more consistent name `~/.user.zsh` (bb76750) by kRHYME7 * chore Merge branch 'master' of https://github.com/hyde-project/hyde into dev (1254f3f) by kRHYME7 * chore Merge branch 'master' into dev (73efd7c) by Khing --- Please review the changes carefully before merging.
As per described in hyrplock documentation, it provides `$LAYOUT` variable https://wiki.hyprland.org/Hypr-Ecosystem/hyprlock/#variable-substitution Using it simplifies kbd layout detection
Contributor
|
Yes this is perfect. Thank you! |
Contributor
|
wait you missed 1 file. This one too please |
Contributor
Author
Oh, will fix it, thanks for noting! |
Contributor
Author
|
@kRHYME7 all done |
kRHYME7
added a commit
that referenced
this pull request
May 16, 2025
This is an automated PR to promote changes from `dev` to `master`. Please review and test before merging. ## For Testers See [TESTING.md](./TESTING.md) for complete testing instructions. ## Suggested Merge Schedule According to our release policy, this PR is expected to be merged on: **Friday** Testers are encouraged to test the changes before merging. Please note that this schedule may be adjusted based on the needs of the project. ## Commits to be merged: --- * chore breaking(input): Unset `# force_no_accel` (ca5f316) by kRHYME7 * fix [Bug]: Importing themes #614 (188890e) by kRHYME7 * fixup: manage `hyprsunset` through `hyprctl` to avoid color flickering (#613) (547afe0) by Ilya Bogdanov * fixup: improve launch of system monitor if it was closed without `sysmonlaunch.sh` (#616) (c319958) by Ilya Bogdanov * fixup: improve padding of `arch` glyph (#615) (cdfc615) by Ilya Bogdanov * chore Fixup rofi launch config (#611) (16c5ff0) by Ilya Bogdanov * chore refactor: use hyprlock provided `$LAYOUT` for detecting current keyboard layout (#609) (6acd79f) by Ilya Bogdanov * fix(zsh): zsh-autosuggestions won't work on first prompt when deferred (#605) (843855a) by Khing --- Please review the changes carefully before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
As per described in hyrplock documentation, it provides
$LAYOUTvariablehttps://wiki.hyprland.org/Hypr-Ecosystem/hyprlock/#variable-substitution
Using it simplifies keyboard layout detection in hyprlock. No need for custom scripts, no need for update interval. Variable is updated immediately when keyboard layout is switched.
Type of change
Please put an
xin the boxes that apply:Checklist
Please put an
xin the boxes that apply: