Skip to content

Conversation

@zeerayne
Copy link
Contributor

Pull Request

Description

According to provided config schema there is typo in config.

This PR fixes typo and renames [rofi.launcher] -> [rofi.launch] to match schema.

I have tested this change in and looks like now scale is applied correctly to rofi application menu.

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added a changelog entry.
  • I have added necessary comments/documentation to my code.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Metalhearf and others added 7 commits May 4, 2025 23:08
This is an automated PR to promote changes from `dev` to `master`.
Please review and test before merging.

## For Testers
See [TESTING.md](./TESTING.md) for complete testing instructions.

## Suggested Merge Schedule
According to our release policy, this PR is expected to be merged on:
**Friday**
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the
project.
## Commits to be merged:
---
* chore Add keybind for game launcher (HyDE-Project#597) (891b181) by ProfShiba
* feat (hyde-ipc): Our very own IPC handler! (5c4221f) by kRHYME7
* fix(zsh): Use `.user.zsh` (f1446ab) by kRHYME7
* feat(hyde-config): A Go implementation of the parse.config.py
(b6c7bb8) by kRHYME7
* chore Add missing modules to Starship config (HyDE-Project#577) (12d113b) by
prime-run
* fix: [Bug]: Defer oh-my-zsh loading may not be the best option HyDE-Project#578
(882fef0) by kRHYME7
* chore implement fzf-shell integration for `fish` (HyDE-Project#575) (e750c97) by
prime-run
* fix(fastfetch): Correct random handler (3cb0434) by kRHYME7
* chore add best fzf aliases ever (HyDE-Project#569) (503711a) by prime-run
* fix(zsh): Explicit history integration (55721cb) by kRHYME7
* fixed the link color being same as normal text (HyDE-Project#570) (ca3c158) by
amit
* fix: [Bug]: Game Launcher isn't showing anything HyDE-Project#447 (96be51a) by
kRHYME7
* chore style: discord dcol file changes (HyDE-Project#566) (63a2949) by amit
* chore refactor(zsh): cleanup zsh for incoing fzf features (abc1a7b)
by prime-run
* chore breaking(zsh): move ~/.hyde.zshrc to more consistent name
`~/.user.zsh` (bb76750) by kRHYME7
* chore Merge branch 'master' of https://github.com/hyde-project/hyde
into dev (1254f3f) by kRHYME7
* chore Merge branch 'master' into dev (73efd7c) by Khing
---

Please review the changes carefully before merging.
@kRHYME7 kRHYME7 merged commit 16c5ff0 into HyDE-Project:dev May 11, 2025
2 checks passed
@zeerayne zeerayne deleted the fixup-rofi-launch-config branch May 11, 2025 18:44
kRHYME7 added a commit that referenced this pull request May 16, 2025
This is an automated PR to promote changes from `dev` to `master`.
Please review and test before merging.

## For Testers
See [TESTING.md](./TESTING.md) for complete testing instructions.

## Suggested Merge Schedule
According to our release policy, this PR is expected to be merged on:
**Friday**
Testers are encouraged to test the changes before merging.
Please note that this schedule may be adjusted based on the needs of the
project.
## Commits to be merged:
---
* chore breaking(input): Unset `# force_no_accel` (ca5f316) by kRHYME7
* fix [Bug]: Importing themes #614 (188890e) by kRHYME7
* fixup: manage `hyprsunset` through `hyprctl` to avoid color flickering
(#613) (547afe0) by Ilya Bogdanov
* fixup: improve launch of system monitor if it was closed without
`sysmonlaunch.sh` (#616) (c319958) by Ilya Bogdanov
* fixup: improve padding of `arch` glyph (#615) (cdfc615) by Ilya
Bogdanov
* chore Fixup rofi launch config (#611) (16c5ff0) by Ilya Bogdanov
* chore refactor: use hyprlock provided `$LAYOUT` for detecting current
keyboard layout (#609) (6acd79f) by Ilya Bogdanov
* fix(zsh): zsh-autosuggestions won't work on first prompt when deferred
(#605) (843855a) by Khing
---

Please review the changes carefully before merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants