Deprecated subgraph functions in CGDFG

[Affie]

DistributedFactorGraphs.jl/src/CloudGraphsDFG/services/CloudGraphsDFG.jl

Lines 465 to 492 in eaea68c

	function getSubgraphAroundNode(dfg::CloudGraphsDFG, node::DFGNode, distance::Int64=1, includeOrphanFactors::Bool=false, addToDFG::AbstractDFG=_getDuplicatedEmptyDFG(dfg); solvable::Int=0)::AbstractDFG
	distance < 1 && error("getSubgraphAroundNode() only works for distance > 0")
	# Thank you Neo4j for 0..* awesomeness!!
	neighborList = _getLabelsFromCyphonQuery(dfg.neo4jInstance,
	"""
	(n:$(dfg.userId):$(dfg.robotId):$(dfg.sessionId):$(node.label))-[FACTORGRAPH*0..$distance]-(node:$(dfg.userId):$(dfg.robotId):$(dfg.sessionId))
	WHERE (n:VARIABLE OR n:FACTOR OR node:VARIABLE OR node:FACTOR)
	and not (node:SESSION)
	and (node.solvable >= $solvable or node:$(dfg.userId):$(dfg.robotId):$(dfg.sessionId):$(node.label))""" # Always return the root node
	)
	# Copy the section of graph we want
	_copyIntoGraph!(dfg, addToDFG, neighborList, includeOrphanFactors)
	return addToDFG
	end
	function getSubgraph(dfg::CloudGraphsDFG,
	variableFactorLabels::Vector{Symbol},
	includeOrphanFactors::Bool=false,
	addToDFG::G=_getDuplicatedEmptyDFG(dfg) )::G where {G <: AbstractDFG}
	# Making a copy session if not specified
	_copyIntoGraph!(dfg, addToDFG, variableFactorLabels, includeOrphanFactors)
	return addToDFG
	end

see

• Refactor graph copy and subgraph functions #373
• Refactor graph copy functions #300
• copyGraph separate variables factors #376

[dehann]

hi, thanks for finding this. although this needs work, i would recommend deferring the effort in the short term and only return to consolidate cgdfg subgraph when it becomes really necessary or sensible to do so. If we can limp along on current cgdfg implementation for a while, that should be okay.

[Affie]

It looks like more of a maintenance thing with the functions missed with the deletion of the deprecations.

However, CGDFG can still overwrite buildSubgraph and/or copyGraph! for performance.

[dehann]

Also listing here in case it isn't/hasn't been elsewhere for DFG:

• https://juliagraphs.org/LightGraphs.jl/latest/operators/#LightGraphs.egonet-Union{Tuple{U},%20Tuple{T},%20Tuple{AbstractGraph{T},Integer,Integer,AbstractArray{U,2}}}%20where%20U%3C:Real%20where%20T%3C:Integer
• https://juliagraphs.org/LightGraphs.jl/latest/operators/#LightGraphs.induced_subgraph-Union{Tuple{U},%20Tuple{AG},%20Tuple{AG,AbstractArray{U,1}}}%20where%20U%3C:Integer%20where%20AG%3C:AbstractGraph