-
Notifications
You must be signed in to change notification settings - Fork 144
[TASK] Deprecate Document::expandShorthands
#566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Deprecate Document::expandShorthands
#566
Conversation
Document::expandShorthands()
Document::expandShorthands
ed21eac
to
0a9c7e6
Compare
Rebased it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the OP comment should somehow be included in the CHANGELOG, so that it would be in turn included in the release note, so that people are directed to previous functionality if they want to implement it themselves as a separate libraray. Maybe immediately under the heading ## x.y.z
. @oliverklee WDYT?
Originally I had this comment within the first PR of this series in the Readme.md at the very bottom. |
I think it suffices to have the pair of "deprecate this" and (in the next release) "remove this" in the changelog. This pattern always means for developers to "please stop using this, and use something else instead or stick to an old version" and "the same, but definitely now". |
Signed-off-by: Daniel Ziegenberg <[email protected]>
0a9c7e6
to
239b1dc
Compare
It's rebased. |
The
expandShorthands
/createShorthands
Functions are deprecated and will be removed without substitution in version 10.0. Expanding and creating the shorthand notation is out of the scope of this library. If you want to include this functionality in your project or build it into a separate package, get the code from the v8.5.1 version of this library.Helps with fixing #512