-
Notifications
You must be signed in to change notification settings - Fork 144
[TASK] Deprecate Document::createShorthands
#567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
oliverklee
merged 1 commit into
MyIntervals:main
from
ziegenberg:deprecate-shorthand-functions_3
Jun 19, 2024
Merged
[TASK] Deprecate Document::createShorthands
#567
oliverklee
merged 1 commit into
MyIntervals:main
from
ziegenberg:deprecate-shorthand-functions_3
Jun 19, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Ziegenberg <[email protected]> a9IH@mns6DLdp# Please enter the commit message for your changes. Lines starting
d53391e
to
9532ac8
Compare
Rebased it. |
oliverklee
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
ziegenberg
added a commit
to ziegenberg/PHP-CSS-Parser
that referenced
this pull request
Jun 19, 2024
Signed-off-by: Daniel Ziegenberg <[email protected]>
oliverklee
added a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
expandShorthands
/createShorthands
Functions are deprecated and will be removed without substitution in version 10.0. Expanding and creating the shorthand notation is out of the scope of this library. If you want to include this functionality in your project or build it into a separate package, get the code from the v8.5.1 version of this library.Helps with fixing #512