Skip to content

Conversation

@gkorland
Copy link
Contributor

No description provided.

@gkorland gkorland requested a review from DvirDukhan September 15, 2020 10:51
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #38 into master will increase coverage by 0.50%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   90.23%   90.73%   +0.50%     
==========================================
  Files          12       12              
  Lines         512      529      +17     
==========================================
+ Hits          462      480      +18     
+ Misses         50       49       -1     
Impacted Files Coverage Δ
...RedisTimeSeries/DataTypes/TimeSeriesInformation.cs 80.00% <ø> (ø)
NRedisTimeSeries/TimeSeriesClientResponseParser.cs 93.44% <93.75%> (+2.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b05b45d...ee5b8a8. Read the comment docs.

@gkorland gkorland added the bug Something isn't working label Sep 15, 2020
@lgtm-com
Copy link

lgtm-com bot commented Sep 15, 2020

This pull request introduces 1 alert when merging 98769be into b05b45d - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

/// Maximum Number of samples per Memory Chunk.
/// </summary>
[ObsoleteAttribute("This method has been deprecated. Use ChunkSize instead.")]
[ObsoleteAttribute("This method has been deprecated. Use ChunkSize instead.")]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo changes in this file, it is only formatting

@DvirDukhan DvirDukhan merged commit 2fe4f47 into master Sep 16, 2020
@DvirDukhan DvirDukhan deleted the fix_info_parse branch September 16, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants