Skip to content

handle new entry arg for __init__() #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

dhalbert
Copy link
Contributor

Support how adafruit-circuitpython-ble 8.0.0 works. AdafruitService.__init__() must now handle creating both sent and received advertisements.

Tested with simpletest client (on Linux) and server (on nRF).

@dhalbert dhalbert requested a review from tannewt April 15, 2021 21:28
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry I missed it.

@tannewt tannewt merged commit 9d87adc into adafruit:master Apr 16, 2021
@dhalbert dhalbert deleted the init-entry branch April 16, 2021 16:00
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 17, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_PCT2075 to 1.1.9 from 1.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCT2075#16 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHTC3 to 1.1.0 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHTC3#9 from jposada202020/using_reset

Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermistor to 3.3.6 from 3.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Thermistor#16 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.4.1 from 1.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#44 from jposada202020/Including_examples_in_the_API

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Adafruit to 1.3.0 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Adafruit#12 from dhalbert/init-entry
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIFX to 1.10.0 from 1.9.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#11 from todbot/master
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants