Changes on the _chip_id

[jposada202020]

This is an attempt to solve #8.
When troubleshooting this, I found two solutions, first is removing the @property and using the _chip_id as a normal function.

However this solutions works better as we do not need to change the logic. I found that the problem was when trying to write .
This solve also the problem of resetting the device with the sensor connected as mention in the Adafruit earning guide.

As I cannot figure out why this work, please test, and feel free to reject this PR if this solution is not desired

I test this on

Adafruit CircuitPython 6.2.0-beta.3-188-g05ed179e1 on 2021-03-15; Adafruit Feather RP2040 with rp2040

[anecdata]

Before PR:

Adafruit CircuitPython 6.2.0 on 2021-04-05; Adafruit MagTag with ESP32S2
>>> import board
>>> import adafruit_shtc3
>>> i2c = board.I2C()
>>> shtc3 = adafruit_shtc3.SHTC3(i2c)
>>> shtc3._chip_id
2119
>>> dir(shtc3)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "adafruit_shtc3.py", line 112, in _chip_id
  File "adafruit_shtc3.py", line 112, in _chip_id
OSError: [Errno 19] Unsupported operation

After PR:

Adafruit CircuitPython 6.2.0 on 2021-04-05; Adafruit MagTag with ESP32S2
>>> import board
>>> import adafruit_shtc3
>>> i2c = board.I2C()
>>> shtc3 = adafruit_shtc3.SHTC3(i2c)
>>> shtc3._chip_id
2119
>>> dir(shtc3)
['__class__', '__dict__', '__init__', '__module__', '__qualname__', 'i2c_device', 'reset', 'temperature', '_buffer', 'low_power', 'sleeping', '_chip_id', '_write_command', '_cached_sleep', '_low_power', 'relative_humidity', 'measurements', '_crc8']

[ladyada]

oof i feel like its risky to reset the chip when asking for the ID - the right thing to do is not let folks call _chip_id? we could remove the funciton

[jposada202020]

@anecdata Thank you for testing :)
@ladyada agree with you, we could just remove it, but as you can see in

Adafruit_CircuitPython_SHTC3/adafruit_shtc3.py

Line 120 in 9a15caf

self.reset()

We already reset the sensor to get the ID number and verify that is in the I2C bus in the class constructor that is how I arrive to this proposal, but I could change the PR to remove the _chip_id function. Let me know. and thanks :)

[ladyada]

yeah we should just move the chip id grabber into the init code

[jposada202020]

will do Thanks

[jposada202020]

This is my interpretation of the requested changes. Resetting the board with the sensor still work, open the possibility to remove the red warning in the learning guide. (to be tested by the person that made that guide)

Adafruit CircuitPython 6.2.0-beta.3-188-g05ed179e1 on 2021-03-15; Adafruit Feather RP2040 with rp2040
>>> import time
>>> import busio
>>> import board
>>> import adafruit_shtc3
>>> 
>>> i2c = busio.I2C(board.SCL, board.SDA)
>>> sht = adafruit_shtc3.SHTC3(i2c)
>>> 
>>> dir(sht)
['__class__', '__dict__', '__init__', '__module__', '__qualname__', 'i2c_device', 'reset', 'temperature', '_buffer', 'low_power', 'sleeping', '_chip_id', '_get_chip_id', '_write_command', '_cached_sleep', '_low_power', 'relative_humidity', 'measurements', '_crc8']
>>> 

Also tested with the simpletest

Adafruit CircuitPython 6.2.0-beta.3-188-g05ed179e1 on 2021-03-15; Adafruit Feather RP2040 with rp2040
>>> import shtc3_simpletest
Temperature: 25.1 C
Humidity: 43.7 %

Temperature: 25.2 C
Humidity: 43.7 %

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "shtc3_simpletest.py", line 17, in <module>
KeyboardInterrupt: 
>>> 

However one last thing, not getting the device id as @anecdata

I am getting

>>> sht._chip_id
2183

[ladyada]

maybe try printing it in hex?

[jposada202020]

you are right, 🤦🏼 , I changed the logic to get the right chip identifier.

Adafruit CircuitPython 6.2.0-beta.3-188-g05ed179e1 on 2021-03-15; Adafruit Feather RP2040 with rp2040
>>> import time
>>> import busio
>>> import board
>>> import adafruit_shtc3
>>> 
>>> i2c = busio.I2C(board.SCL, board.SDA)
>>> sht = adafruit_shtc3.SHTC3(i2c)
>>> 
>>> sht._chip_id
2055
>>> 

2055 = _SHTC3_CHIP_ID = 0x807

Adafruit_CircuitPython_SHTC3/adafruit_shtc3.py

Line 77 in 9a15caf

_SHTC3_CHIP_ID = 0x807