Skip to content

Add support for adafruit_requests.Session #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 15, 2021
Merged

Add support for adafruit_requests.Session #11

merged 6 commits into from
Apr 15, 2021

Conversation

todbot
Copy link
Contributor

@todbot todbot commented Apr 15, 2021

Currently adafruit_lifx supports older adafruit_esp32spi_wifimanager. This PR adds support for adafruit_requests.Session

@ladyada ladyada requested a review from jedgarpark April 15, 2021 12:36
jedgarpark
jedgarpark approved these changes Apr 15, 2021
View reviewed changes
Copy link

@jedgarpark jedgarpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this on the Funhouse, it works great. Haven't tested for backwards compatibility with an older ESP32 board, but it looks like this handles that case.

@ladyada ladyada merged commit edf4346 into adafruit:master Apr 15, 2021
@brentru
Copy link
Member

brentru commented Apr 15, 2021

@todbot For compatibility with ESP32SPI, do we want to update this to also support the request object (see: https://github.com/adafruit/Adafruit_CircuitPython_Requests/blob/master/examples/requests_simpletest.py#L51) instead of having the WiFiManager handle everything?

@todbot
Copy link
Contributor Author

todbot commented Apr 15, 2021

@brentru I created a separate example called lifx_simpletest_esp32s2.py that uses the adafruit_request Session and not disturb the existing example that uses ESP32SPI. Is that what you mean? (I admit I don't fully understand how adafruit_requests and the older WiFi Manager stuff coexist)

@brentru
Copy link
Member

brentru commented Apr 15, 2021 •
edited
Loading

@todbot thats fine :) thanks for updating the library

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 17, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@41b2432)
b8a918e 
Updating https://github.com/adafruit/Adafruit_CircuitPython_PCT2075 to 1.1.9 from 1.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCT2075#16 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHTC3 to 1.1.0 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHTC3#9 from jposada202020/using_reset

Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermistor to 3.3.6 from 3.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_Thermistor#16 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.4.1 from 1.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#44 from jposada202020/Including_examples_in_the_API

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Adafruit to 1.3.0 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Adafruit#12 from dhalbert/init-entry
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIFX to 1.10.0 from 1.9.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#11 from todbot/master
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedgarpark jedgarpark jedgarpark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@todbot @brentru @jedgarpark @ladyada