-
Notifications
You must be signed in to change notification settings - Fork 2
Fix Github Actions workflow #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
reviewed
Nov 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Tagging Dylan in for final review!
evaherrada
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tekktrik Thanks! |
My pleasure! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 24, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_LC709203F to 2.2.0 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_LC709203F#17 from kattni/add-400-pack-size > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8563 to 1.0.0 from 0.9.0: > Moved PR template > Merge pull request adafruit/Adafruit_CircuitPython_PCF8563#3 from tekktrik/hotfix/fix-errors > Updated readthedocs file > Updated readthedocs requirements path > add docs link to readme > Added pylint disable for f-strings in tests directory > Globally disabled consider-using-f-string pylint check Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 8.1.2 from 8.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#144 from FoamyGuy/rtd_version > Merge pull request adafruit/Adafruit_CircuitPython_BLE#142 from adafruit/patch-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Ticks to 1.0.0 from 0.9.2: > Merge pull request adafruit/Adafruit_CircuitPython_Ticks#3 from FoamyGuy/install_command > Merge pull request adafruit/Adafruit_CircuitPython_Ticks#2 from adafruit/patch > Updated readthedocs file > Updated readthedocs requirements link > Added pylint disable for f-strings in tests directory > Globally disabled consider-using-f-string pylint check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also brought along the other missing commits! Address #2 as well.