This repository was archived by the owner on Nov 27, 2018. It is now read-only.
Revert Dispatcher changes #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
approved these changes
Jan 9, 2018
There was a problem hiding this comment.
Seems ok to me.
- Could you re-open Tolerate a leading / or ~/ on conventional routes #441 and triage it for preview1?
- Build Mvc using these changes and verify things continue working?
| @@ -12,7 +12,6 @@ namespace Microsoft.AspNetCore.Routing | |||
| { | |||
| public class RouteCollection : IRouteCollection | |||
| { | |||
| private readonly static char[] UrlQueryDelimiters = new char[] { '?', '#' }; | |||
There was a problem hiding this comment.
Could you revert this file?
|
Do get signoff from @rynowak |
jbagga
force-pushed
the
jbagga/RevertDispatcher2741
branch
from
516f07e to
02058cc
Compare
|
Verified MVC builds locally, reopened #441 and reverted RouteCollection |
|
@rynowak Updated with changes Pranav suggested. Waiting for your sign off |
|
@rynowak Updated. You should expect to see that the Routing benchmarks project has moved from test to benchmarks directory. |
rynowak
approved these changes
Jan 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses dotnet/aspnetcore#2741