Skip to content
This repository was archived by the owner on Oct 18, 2018. It is now read-only.

Remove Dispatcher packages #774

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Remove Dispatcher packages #774

merged 2 commits into from
Jan 11, 2018

Conversation

jbagga
Copy link
Contributor

@jbagga jbagga commented Jan 11, 2018

@natemcmaster
Copy link
Contributor

PR check is currently failing:

/home/travis/build/aspnet/Universe/build/repo.targets(162,5): error : Undeclared package artifacts. Add these to artifacts.props: [/home/travis/.dotnet/buildtools/korebuild/2.1.0-preview1-15667/KoreBuild.proj]
/home/travis/build/aspnet/Universe/build/repo.targets(162,5): error :   - Microsoft.AspNetCore.Routing.UrlMatchingTree.Sources [/home/travis/.dotnet/buildtools/korebuild/2.1.0-preview1-15667/KoreBuild.proj]
/home/travis/build/aspnet/Universe/build/repo.targets(162,5): error :   - Microsoft.AspNetCore.Dispatcher.Abstractions [/home/travis/.dotnet/buildtools/korebuild/2.1.0-preview1-15667/KoreBuild.proj]
/home/travis/build/aspnet/Universe/build/repo.targets(162,5): error :   - Microsoft.AspNetCore.Dispatcher [/home/travis/.dotnet/buildtools/korebuild/2.1.0-preview1-15667/KoreBuild.proj]

I assume aspnet/Routing#508 is the change that removed these packages. For breaking changes like this, you have to do a manual step to update universe. If this change is on the dev branch, you can update like this

  1. git submodule update --init --remote modules/Routing
  2. git add modules/Routing
  3. git commit

@natemcmaster
Copy link
Contributor

Feel free to merge even though AppVeyor isn't done. EF Core is currently filling up the AppVeyor queue so it make take a while to get to this PR.

@jbagga jbagga merged commit 3d9af2e into dev Jan 11, 2018
@natemcmaster natemcmaster deleted the jbagga/RemoveDispatcherPackages branch January 17, 2018 01:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants