-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Remove code not shipping in 2.1 release #2741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Just FYI - as an alternative to deleting the code altogether, you can just prevent it from ending up in a NuGet package by setting this property in the csproj file. <IsPackable>false</IsPackable> We've done this in other repos where half-baked coded wasn't finished in time for a release. |
@rynowak Since some Routing APIs now depend on stuff in the Dispatcher projects, will it be safe to just add @natemcmaster Is there a way to test if things will be broken or not if some projects are NuGet packages and others aren't? |
You would need to remove these packages from this list: You can verify this works in universe by doing the following:
|
This is not going to work. Routing now has a dependency on Dispatcher, that part needs to be reverted. |
There was some Dispatcher related code introduced to the routing repo, as part of a feature which was pushed out. So that code needs to be taken out.
@rynowak, can you please provide details about exactly should be removed?
The text was updated successfully, but these errors were encountered: