Skip to content

Remove code not shipping in 2.1 release #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkArtakMSFT opened this issue Jan 4, 2018 · 4 comments
Closed

Remove code not shipping in 2.1 release #2741

mkArtakMSFT opened this issue Jan 4, 2018 · 4 comments
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed task

Comments

@mkArtakMSFT
Copy link
Contributor

There was some Dispatcher related code introduced to the routing repo, as part of a feature which was pushed out. So that code needs to be taken out.
@rynowak, can you please provide details about exactly should be removed?

@natemcmaster
Copy link
Contributor

Just FYI - as an alternative to deleting the code altogether, you can just prevent it from ending up in a NuGet package by setting this property in the csproj file.

<IsPackable>false</IsPackable>

We've done this in other repos where half-baked coded wasn't finished in time for a release.

@jbagga
Copy link
Contributor

jbagga commented Jan 5, 2018

@rynowak Since some Routing APIs now depend on stuff in the Dispatcher projects, will it be safe to just add <IsPackable>false</IsPackable> to Dispatcher projects?

@natemcmaster Is there a way to test if things will be broken or not if some projects are NuGet packages and others aren't?

@natemcmaster
Copy link
Contributor

You would need to remove these packages from this list:
https://github.com/aspnet/Universe/blob/dev/build/artifacts.props#L63-L64

You can verify this works in universe by doing the following:

  1. git clone --recursive https://github.com/aspnet/Universe
  2. Edit modules/Routing to remove the dispatcher packages)
  3. Run build.cmd /t:ComputeGraph in universe. This will examine all projects to ensure the graph of package dependencies is correctly defined.

@rynowak
Copy link
Member

rynowak commented Jan 5, 2018

Just FYI - as an alternative to deleting the code altogether, you can just prevent it from ending up in a NuGet package by setting this property in the csproj file.

This is not going to work. Routing now has a dependency on Dispatcher, that part needs to be reverted.

jbagga added a commit to aspnet/Routing that referenced this issue Jan 10, 2018
@jbagga jbagga added Done This issue has been fixed and removed 2 - Working labels Jan 11, 2018
@jbagga jbagga closed this as completed Jan 11, 2018
@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Nov 7, 2018
@Eilon Eilon unassigned jbagga Nov 7, 2018
@Eilon Eilon removed the repo:Routing label Nov 7, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Done This issue has been fixed task
Projects
None yet
Development

No branches or pull requests

5 participants