feat(autoware_trajectory_follower_node): adopt cie#12320
feat(autoware_trajectory_follower_node): adopt cie#12320TetsuKawa wants to merge 8 commits intoautowarefoundation:mainfrom
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12320 +/- ##
==========================================
+ Coverage 18.54% 19.49% +0.95%
==========================================
Files 1850 1877 +27
Lines 128011 129040 +1029
Branches 45591 47895 +2304
==========================================
+ Hits 23736 25154 +1418
- Misses 84599 85418 +819
+ Partials 19676 18468 -1208
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
104a58b to
822a9cd
Compare
There was a problem hiding this comment.
Pull request overview
Adopts autoware_agnocast_wrapper in autoware_trajectory_follower_node so the node can switch between the standard ROS 2 executor and CallbackIsolatedAgnocastExecutor (CIE) via ENABLE_AGNOCAST.
Changes:
- Register both component nodes via
autoware_agnocast_wrapper_register_nodewith explicit ROS 2 and Agnocast executor types. - Add
autoware_agnocast_wrapperbuild configuration and dependency wiring (CMake + package.xml).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| control/autoware_trajectory_follower_node/package.xml | Adds runtime/build dependency on autoware_agnocast_wrapper. |
| control/autoware_trajectory_follower_node/CMakeLists.txt | Integrates agnocast wrapper into both component targets and switches registration macro. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
This PR adopts autoware_agnocast_wrapper in autoware_trajectory_follower_node so the node can switch between the default ROS 2 executor and CallbackIsolatedAgnocastExecutor based on the ENABLE_AGNOCAST environment variable.
Changes:
- Add
autoware_agnocast_wrapperas a package dependency. - Update component registration in
CMakeLists.txtto useautoware_agnocast_wrapper_*macros and configure ROS2/agnocast executors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| control/autoware_trajectory_follower_node/package.xml | Adds runtime/package dependency on autoware_agnocast_wrapper. |
| control/autoware_trajectory_follower_node/CMakeLists.txt | Switches node registration to agnocast wrapper and sets executor options for both components. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
e79f256 to
1c65ed9
Compare
1c65ed9 to
1296465
Compare
Signed-off-by: TetsuKawa <kawaguchitnon@icloud.com>
Description
Apply
autoware_agnocast_wrapperto enableCallbackIsolatedAgnocastExecutor(CIE) for this package, as part of the effort to achieve middleware-transparent scheduling and optimize end-to-end response time across Autoware. By going throughautoware_agnocast_wrapper, CIE activation is controlled by theENABLE_AGNOCASTenvironment variable — when unset or0, the node runs with the standard ROS 2 executor as before; when set to1, it switches toCallbackIsolatedAgnocastExecutor.Changes
Related links
How was this PR tested?
Notes for reviewers
Please review the following aspects:
CMakeLists.txtand launch files in this package have been updated (no missed files).SingleThreadedExecutorInterface changes
None.
Effects on system behavior
When
ENABLE_AGNOCAST=0(default), there is no change in behavior at all — the node runs with the standard ROS 2 executor exactly as before.When
ENABLE_AGNOCAST=1, the executor switches toCallbackIsolatedAgnocastExecutor(CIE). Internally, CIE creates a dedicatedrclcpp::SingleThreadedExecutorfor each callback group, so the fundamental scheduling behavior within each group remains almost identical. The key difference is that, for nodes originally usingSingleThreadedExecutor, callback groups now run in parallel across separate threads, similar toMultiThreadedExecutor.