feat(autoware_behavior_path_side_shift_module): accept service inputs and add publisher to inform the current shift length#12474
Open
TaikiYamada4 wants to merge 9 commits intoautowarefoundation:mainfrom
Conversation
…vior_path_planner and autoware_behavior_path_planner_common Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
…n for lateral_offset inputs Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
7 tasks
…us codes in README Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
side_shiftmodule of theautoware_behavior_path_planneris somewhat a special module that is outside the frame of Dynamic Driving Tasks (DDT) because this module is aimed to modify the path laterally by a human hand.Currently this feature obtains its shift length from a topic, however this will not tell the operator to know whether the requested shift_length is successfully received or not. Hence, this PR adds a new service to
autoware_behavior_path_side_shift_module.In addition the newly implemented service not only accepts direct shift length, but also adds a new shift mode that can send whether to go left or right. If this shift mode is selected the vehicle will shift its path with the shift length stated in the
unit_shift_amountparameter. This unit shift will be accumulated as the shift request with the same direction has come.Related links
How was this PR tested?
colcon testpasses.side_shift_service-2026-04-06_11.01.08.mp4
RAW_VALUEmode with1.0meterRAW_VALUEmode with-1.0meterDIRECTIONmode and selectRESET(=0)DIRECTIONmode and selectLEFT(=1)several times. This shifts the path0.1meter eachDIRECTIONmode and selectRIGHT(=2)several times. This shifts the path0.1meter eachRAW_VALUEmode with3.0meters but the request declined since it exceeds threshold.Notes for reviewers
I've moved the lateral_offset subscriber to the side_shift module to
requested_lateral_offset_from both topic and service correctlyplanner_data_from the module sideTherefore, the
lateral_offsetfield is removed from theplanner_data_.Besides, the current CI doesn't pass because the srv type must be merged first
Interface changes
Topic changes
Additions and removals
~/set_lateral_offsettier4_planning_msgs/SetLateralOffset~/output/lateral_offsettier4_planning_msgs/LateralOffsetROS Parameter Changes
Additions and removals
max_shift_magnitudedouble1.0[m]min_shift_gapdouble0.001[m]unit_shift_amountdouble0.1[m]set_lateral_offsetservice.Effects on system behavior
autoware_behavior_path_side_shift_moduleaccepts ROS 2 service inputsmax_shift_magnitudemeters