Use current working directory if no `package.json` #1044

sotojuan · 2016-09-21T14:19:54Z

Currently we give a nasty error when AVA is ran in a directory with no package.json. If none is found, we fallback to the current working directory.

sotojuan · 2016-09-21T14:29:01Z

This might interfere with #32, not sure.

novemberborn · 2016-09-22T09:42:40Z

cli.js

+
+try {
+	pkgDir = path.dirname(pkgConf.filepath(conf));
+} catch (err) {


Check if pkgConf.filepath(conf) returns null instead. If it does, use process.cwd(), else call path.dirname() with the return value.

sotojuan · 2016-09-22T14:10:05Z

Done!

sindresorhus · 2016-09-22T16:44:52Z

cli.js

+	pkgDir = process.cwd();
+} else {
+	pkgDir = path.dirname(filepath);
+}


Would be better as a simple ternary:

var pkgDir = filepath === null ? process.cwd() : path.dirname(filepath);

sotojuan · 2016-09-22T19:05:23Z

Right, of course :p Fixed.

jamestalmage · 2016-09-23T03:38:53Z

Any way to test this?

I'm thinking something like:

const dir = uniqueTempDir({create: true});
const testFilePath = path.join(dir, 'test.js');
const cliPath = require.resolve('../../cli.js');

fs.writeFileSync(testFilePath, `
  import test from 'ava';

  test(t => {
    t.pass();
  });
`);

execa(process.execPath, [cliPath], {cwd: dir}).then(endTheTest);

sindresorhus · 2016-10-06T04:10:38Z

@sotojuan Could you add a test?

sotojuan · 2016-10-06T11:11:57Z

Yep, sorry I got busy these past two weeks! Test + improvements coming up soon.

sotojuan · 2016-10-10T16:44:21Z

Any idea of why it's failing? Works locally (and test critique please).

vadimdemedes · 2016-10-10T17:18:25Z

Also passed locally on clean node_modules without a problem.

sindresorhus · 2016-10-10T17:35:20Z

test/cli.js

+	var dir = uniqueTempDir({create: true});
+	var testFilePath = path.join(dir, 'test.js');
+	var cliPath = require.resolve('../cli.js');
+	var avaPath = require.resolve('../index.js');


var avaPath = require.resolve('../');

sindresorhus · 2016-10-10T17:35:34Z

test/cli.js

@@ -368,3 +371,17 @@ test('prefers local version of ava', function (t) {
 	t.ok(debugSpy.calledWith('Using local install of AVA'));
 	t.end();
 });
+
+test('use current working directory if `package.json` is not found', function (t) {
+	var dir = uniqueTempDir({create: true});


dir => cwd

sindresorhus · 2016-10-10T17:36:18Z

test/cli.js

+	execa(process.execPath, [cliPath], {cwd: dir}).then(() => {
+		t.pass();
+		t.end();
+	});


It needs to handle a possibly rejected promise too.

I think you should just return the promise. You don't test the output of the command, so no need for manual then/catch. Return a promise and test will fail, if the promise rejects.

👍 Ah true. Forgot node-tap got support for promises.

sotojuan · 2016-10-11T02:29:01Z

Still breaking, but updated.

novemberborn · 2016-10-14T13:56:53Z

@sotojuan I've found why the test was failing, there's another bug where we assume we can always find a cache dir. That's not true when running outside of a directory with a package.json file!

Pushed a fix for that. Also merged master into this branch which is a bit unconventional but I didn't want to force-push ;-) Squash & merge will take care of that for us.

@skovhus

Update test Document more async pitfalls (#1045) * Use tabs in pitfalls code blocks * Spell out async in pitfals doc * Promote async/await in pitfalls doc * Provide example of using pify * Suggest pify for catching exceptions * Suggest promisifying callback-functions for better exception catching Do not say that `t` is the only argument of a test bump all the `babel` related modules to latest Some older versions that are still matched by semver were buggy and some users were somehow getting those versions. Maybe from a stale npm cache. Fixes #1058 bump `tap` and `nyc` highlights - Automatic migration from other test runners Thanks @skovhus! :) Replace `jsdom` with `browser-env` in browser recipe (#1054) Clean up API (#1061) Switch to `lodash.isEqual` for deep quality check (#1063) Add link to first contribution blog post Reduce transpilation on Node.js >=4 (#1068) Better startup performance and improved stack traces. Remove --require CLI option (#1070) Fixes #1069. Fix link to configuration in readme (#1073) make XO happy Locking the version as 0.17.0 requires Node.js 4 Check whether a cache dir was found before attempting to use it AVA will never find a cache dir if it is run in a directory without a package.json file.

sotojuan · 2016-10-14T20:41:38Z

Phew, had to fix some git stuff and merge latest master. If the tests pass I can squash.

sotojuan · 2016-10-14T21:26:36Z

Boo AppVeyor.

sindresorhus · 2016-10-22T05:02:51Z

AppVeyor error:

Error: Cannot find module 'C:projectsavaindex.js

My first thought; Where are the path separators?

novemberborn · 2016-10-23T15:16:04Z

test/cli.js

+	var cliPath = require.resolve('../cli.js');
+	var avaPath = require.resolve('../');
+
+	fs.writeFileSync(testFilePath, 'import test from \'' + avaPath + '\';\ntest(t => { t.pass(); });');


Changing to this probably fixes the AppVeyor error:

'import test from ' + JSON.stringify(avaPath) + ';\ntest(t => { t.pass(); });'

I reckon on Windows the path contains backslashes which are interpreted as escape characters.

sotojuan · 2016-10-23T17:13:45Z

All right I'm pretty sure AppVeyor will like these changes.

sotojuan · 2016-10-23T17:35:34Z

🐔

Changes have been addressed

sotojuan · 2016-10-30T15:55:44Z

Thanks!

Use current working directory if no package.json

33b65a1

sotojuan closed this Sep 21, 2016

sotojuan reopened this Sep 21, 2016

novemberborn requested changes Sep 22, 2016

View reviewed changes

Check for filepath instead

06890db

Fix linting errors

60a20a7

sindresorhus requested changes Sep 22, 2016

View reviewed changes

Use ternary

1c3f115

Add test

fc6d3d7

sindresorhus previously requested changes Oct 10, 2016

View reviewed changes

novemberborn approved these changes Oct 14, 2016

View reviewed changes

Juan Soto added 2 commits October 14, 2016 14:57

Merge branch 'master' into fallback-pkgdir

2235136

sindresorhus force-pushed the master branch 2 times, most recently from 4bc021e to 476c653 Compare October 18, 2016 03:23

novemberborn reviewed Oct 23, 2016

View reviewed changes

Attempt AppVeyor fix

511353f

Juan Soto added 2 commits October 23, 2016 11:58

Merge branch 'master' into fallback-pkgdir

8411bb6

Merge branch 'master' into fallback-pkgdir

a80af78

novemberborn merged commit 59254b7 into avajs:master Oct 30, 2016

sotojuan deleted the fallback-pkgdir branch October 30, 2016 15:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use current working directory if no `package.json` #1044

Use current working directory if no `package.json` #1044

sotojuan commented Sep 21, 2016

sotojuan commented Sep 21, 2016

novemberborn Sep 22, 2016

sotojuan commented Sep 22, 2016

sindresorhus Sep 22, 2016

sotojuan commented Sep 22, 2016

jamestalmage commented Sep 23, 2016

sindresorhus commented Oct 6, 2016

sotojuan commented Oct 6, 2016 •

edited

Loading

sotojuan commented Oct 10, 2016

vadimdemedes commented Oct 10, 2016

sindresorhus Oct 10, 2016

sindresorhus Oct 10, 2016

sindresorhus Oct 10, 2016

vadimdemedes Oct 10, 2016

sindresorhus Oct 10, 2016 •

edited

Loading

sotojuan commented Oct 11, 2016

novemberborn commented Oct 14, 2016

sotojuan commented Oct 14, 2016

sotojuan commented Oct 14, 2016

sindresorhus commented Oct 22, 2016

novemberborn Oct 23, 2016

sotojuan commented Oct 23, 2016

sotojuan commented Oct 23, 2016

sotojuan commented Oct 30, 2016

Use current working directory if no package.json #1044

Use current working directory if no package.json #1044

Conversation

sotojuan commented Sep 21, 2016

sotojuan commented Sep 21, 2016

novemberborn Sep 22, 2016

Choose a reason for hiding this comment

sotojuan commented Sep 22, 2016

sindresorhus Sep 22, 2016

Choose a reason for hiding this comment

sotojuan commented Sep 22, 2016

jamestalmage commented Sep 23, 2016

sindresorhus commented Oct 6, 2016

sotojuan commented Oct 6, 2016 • edited Loading

sotojuan commented Oct 10, 2016

vadimdemedes commented Oct 10, 2016

sindresorhus Oct 10, 2016

Choose a reason for hiding this comment

sindresorhus Oct 10, 2016

Choose a reason for hiding this comment

sindresorhus Oct 10, 2016

Choose a reason for hiding this comment

vadimdemedes Oct 10, 2016

Choose a reason for hiding this comment

sindresorhus Oct 10, 2016 • edited Loading

Choose a reason for hiding this comment

sotojuan commented Oct 11, 2016

novemberborn commented Oct 14, 2016

sotojuan commented Oct 14, 2016

sotojuan commented Oct 14, 2016

sindresorhus commented Oct 22, 2016

novemberborn Oct 23, 2016

Choose a reason for hiding this comment

sotojuan commented Oct 23, 2016

sotojuan commented Oct 23, 2016

sotojuan commented Oct 30, 2016

Use current working directory if no `package.json` #1044

Use current working directory if no `package.json` #1044

sotojuan commented Oct 6, 2016 •

edited

Loading

sindresorhus Oct 10, 2016 •

edited

Loading