Skip to content

Mobile layout in parent component #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pietrop opened this issue Mar 5, 2019 · 1 comment
Closed

Mobile layout in parent component #107

pietrop opened this issue Mar 5, 2019 · 1 comment
Assignees
@pietrop
Labels
bug Something isn't working

Comments

@pietrop
Copy link
Contributor

pietrop commented Mar 5, 2019

Making a quick note, that when installing current version0.3.0 in a parent app that uses react-bootstrap the PlayerControls display: 'flex'; seems to be breaking the mobile view.

screen shot 2019-03-05 at 18 45 27

Zooming out reveals that the the PlayerControls width is effecting the overall layout.

screen shot 2019-03-05 at 18 45 36

When removing flex from PlayerControls, it seems to display "ok" , altho needs thinking through and grouping the elements.

screen shot 2019-03-05 at 18 47 55

Anyway, just a note to remember to revisit after PR #70 to see if after that layout change the problem is fixed
@pietrop pietrop added the bug Something isn't working label Mar 5, 2019
@pietrop pietrop self-assigned this Mar 5, 2019
@pietrop
Copy link
Contributor Author

pietrop commented Mar 15, 2019

closing this as been addressed by #50 - #49 and PRs #70 and #111

@pietrop pietrop closed this as completed Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pietrop pietrop

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pietrop