v10.0.4/service update #41
Conversation
|
Warning Rate limit exceeded@gimlichael has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 38 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThis update increments package dependency versions across multiple project configuration files, updates Docker and test runner image versions, and adds new release notes for version 10.0.4 in several package changelogs. The changes focus on maintaining compatibility with .NET 9 and .NET 8, and updating related documentation. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant Repo as Repository
participant CI as CI/CD Pipeline
participant Docker as Docker Image
participant NuGet as NuGet Packages
Dev->>Repo: Pushes updated dependency versions and docs
Repo->>CI: Triggers build and test
CI->>Docker: Builds new Docker image with updated nginx
CI->>NuGet: Publishes packages with updated dependencies
CI->>Repo: Updates changelog and release notes
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates service dependencies, tooling images, and documentation for version 10.0.4.
- Bumps Docker test runner image to net8.0.412–9.0.302
- Upgrades package versions to 9.0.7 (and TestHost 8.0.18 for net8)
- Refreshes CHANGELOG and per-package release notes for v10.0.4
- Updates DocFX Dockerfile to nginx 1.29.0-alpine
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testenvironments.json | Updated test runner Docker image tag |
| Directory.Packages.props | Bumped Cuemon and Microsoft package versions |
| CHANGELOG.md | Added 10.0.4 changelog entry |
| .nuget/*/PackageReleaseNotes.txt (4 files) | Added version 10.0.4 release notes with dependency changes |
| .docfx/Dockerfile.docfx | Updated nginx base and final images to 1.29.0-alpine |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (5)
.docfx/Dockerfile.docfx (1)
1-1: Remove stray UTF-8 BOM to avoid “unknown instruction” errors in older Docker versions
The leading(byte-order mark) beforeFROMcan cause the Docker parser to choke on some build agents. Save the file as UTF-8 without BOM.CHANGELOG.md (2)
15-16: Grammar nit: use “were”, not “was”“entries prior to version 8.4.0 was migrated…”
-> Changelog entries prior to version 8.4.0 was migrated +> Changelog entries prior to version 8.4.0 were migrated
7-13: Add comparison links for the new tag to stay Keep-a-Changelog compliantEvery version header (
[10.0.x]) should have a matching diff link at the bottom of the file. Remember to append:[10.0.4]: https://github.com/codebeltnet/xunit/compare/v10.0.3...v10.0.4This keeps the autogenerated release notes and GitHub release pages in sync.
.nuget/Codebelt.Extensions.Xunit/PackageReleaseNotes.txt (1)
1-6: Watch out for stray BOM and non-breaking-space characters in the fileGood to see the 10.0.4 entry added, but the file still contains an embedded U+FEFF (BOM) at the beginning of the previous entry (
Version 10.0.3) as well as several hard NBSPs used as “blank” lines.
These invisible control characters tend to sneak into diffs and can break tooling that does strict encoding/whitespace checks.Diff-friendly tidy-up:
-Version 10.0.3 +Version 10.0.3and replace NBSPs with normal CR/LF blank lines.
.nuget/Codebelt.Extensions.Xunit.Hosting/PackageReleaseNotes.txt (1)
1-6: Same encoding issue as the sibling fileThe new 10.0.4 section looks fine, but the file still carries an in-line BOM right before the 10.0.3 header (
Version 10.0.3).
Please strip any stray U+FEFF characters and replace NBSP placeholders with regular blank lines to avoid future diff noise.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
.docfx/Dockerfile.docfx(2 hunks).nuget/Codebelt.Extensions.Xunit.App/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.Xunit.Hosting.AspNetCore/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.Xunit.Hosting/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.Xunit/PackageReleaseNotes.txt(1 hunks)CHANGELOG.md(1 hunks)Directory.Packages.props(2 hunks)testenvironments.json(1 hunks)
🧰 Additional context used
🧠 Learnings (7)
📓 Common learnings
Learnt from: gimlichael
PR: codebeltnet/xunit#17
File: src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj:22-26
Timestamp: 2024-10-09T14:10:40.721Z
Learning: In the `src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj` file, only certain .NET 8 packages are available in version 8.0.1, while others remain at 8.0.0, so package versions may differ due to availability.
.nuget/Codebelt.Extensions.Xunit/PackageReleaseNotes.txt (1)
Learnt from: gimlichael
PR: codebeltnet/xunit#17
File: src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj:22-26
Timestamp: 2024-10-09T14:10:40.721Z
Learning: In the `src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj` file, only certain .NET 8 packages are available in version 8.0.1, while others remain at 8.0.0, so package versions may differ due to availability.
.nuget/Codebelt.Extensions.Xunit.Hosting.AspNetCore/PackageReleaseNotes.txt (1)
Learnt from: gimlichael
PR: codebeltnet/xunit#17
File: src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj:22-26
Timestamp: 2024-10-09T14:10:40.721Z
Learning: In the `src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj` file, only certain .NET 8 packages are available in version 8.0.1, while others remain at 8.0.0, so package versions may differ due to availability.
.nuget/Codebelt.Extensions.Xunit.App/PackageReleaseNotes.txt (1)
Learnt from: gimlichael
PR: codebeltnet/xunit#17
File: src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj:22-26
Timestamp: 2024-10-09T14:10:40.721Z
Learning: In the `src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj` file, only certain .NET 8 packages are available in version 8.0.1, while others remain at 8.0.0, so package versions may differ due to availability.
.nuget/Codebelt.Extensions.Xunit.Hosting/PackageReleaseNotes.txt (1)
Learnt from: gimlichael
PR: codebeltnet/xunit#17
File: src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj:22-26
Timestamp: 2024-10-09T14:10:40.721Z
Learning: In the `src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj` file, only certain .NET 8 packages are available in version 8.0.1, while others remain at 8.0.0, so package versions may differ due to availability.
Directory.Packages.props (1)
Learnt from: gimlichael
PR: codebeltnet/xunit#17
File: src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj:22-26
Timestamp: 2024-10-09T14:10:40.721Z
Learning: In the `src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj` file, only certain .NET 8 packages are available in version 8.0.1, while others remain at 8.0.0, so package versions may differ due to availability.
CHANGELOG.md (1)
Learnt from: gimlichael
PR: codebeltnet/xunit#17
File: src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj:22-26
Timestamp: 2024-10-09T14:10:40.721Z
Learning: In the `src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj` file, only certain .NET 8 packages are available in version 8.0.1, while others remain at 8.0.0, so package versions may differ due to availability.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: call-test (windows-2022, Release) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug) / 🧪 Test
- GitHub Check: call-pack (Debug) / 📦 Pack
- GitHub Check: call-test (ubuntu-24.04, Release) / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
🔇 Additional comments (3)
.docfx/Dockerfile.docfx (1)
1-1: Nginx1.29.0-alpinetag confirmed—no change required
Verification against Docker Hub shows the1.29.0-alpinetag exists, so the currentFROMlines are correct and builds will succeed as is.Likely an incorrect or invalid review comment.
Directory.Packages.props (1)
7-10: ✅ All bumped package versions verified on NuGet.org
Ran the verification script against the following packages; all were found successfully:
- Cuemon.Core (9.0.7)
- Cuemon.Extensions.AspNetCore (9.0.7)
- Cuemon.Extensions.IO (9.0.7)
- Microsoft.Bcl.AsyncInterfaces (9.0.7)
- Microsoft.Extensions.Configuration (9.0.7)
- Microsoft.Extensions.Hosting (9.0.7)
- Microsoft.AspNetCore.TestHost (8.0.18)
No further action required.
testenvironments.json (1)
12-12: Docker image tag verified
The taggimlichael/ubuntu-testrunner:net8.0.412-9.0.302exists in Docker Hub, so the CI/dev-container pull will succeed.
.nuget/Codebelt.Extensions.Xunit.Hosting.AspNetCore/PackageReleaseNotes.txt
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 48 48
Lines 949 949
Branches 122 122
=======================================
Hits 874 874
Misses 65 65
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
gimlichael
deleted the
codex/update-dependencies-and-apply-service-update
branch
1 participant
Summary
Testing
dotnet test -f net8.0(fails: NETSDK1045 due to missing .NET 9.0)https://chatgpt.com/codex/tasks/task_e_68701db271c48330be3cdd6371694ced
Summary by CodeRabbit