-
Notifications
You must be signed in to change notification settings - Fork 1
V10.0.6/service update #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughIncremental maintenance updates: bumped DocFX NGINX base image, updated central package versions (Cuemon, Microsoft.*), refreshed test runner Docker image tag, and added 10.0.6 entries to CHANGELOG and multiple package release notes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This is a service update for version 10.0.6 that focuses on upgrading package dependencies across the project to their latest compatible versions. The PR updates several core and extension packages, along with Microsoft packages for both .NET 9 and .NET 8 target frameworks.
- Updated Cuemon and Microsoft packages to newer versions (9.0.8 → 9.0.9, 8.0.19 → 8.0.20)
- Updated Docker test environment and NGINX versions
- Added release notes for version 10.0.6 across all packages
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
Directory.Packages.props | Updated package versions for Cuemon and Microsoft extensions |
testenvironments.json | Updated Docker test runner image version |
CHANGELOG.md | Added entry for version 10.0.6 service update |
.nuget/*/PackageReleaseNotes.txt | Added release notes for version 10.0.6 across all packages |
.docfx/Dockerfile.docfx | Updated NGINX base image version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage ? 92.09%
=======================================
Files ? 48
Lines ? 949
Branches ? 122
=======================================
Hits ? 874
Misses ? 65
Partials ? 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.docfx/Dockerfile.docfx (1)
3-5
: Remove unused base stage and set explicit WORKDIR; simplify the image graph.The nginx “base” stage is not used (final stage is built from nginx again). Simplify and avoid pulling nginx twice; also make the build stage explicit.
- FROM --platform=$BUILDPLATFORM nginx:${NGINX_VERSION} AS base - RUN rm -rf /usr/share/nginx/html/* - -FROM --platform=$BUILDPLATFORM codebeltnet/docfx:2.78.3 AS build -ADD [".", "docfx"] -RUN cd docfx; \ - docfx build - -FROM nginx:${NGINX_VERSION} AS final -WORKDIR /usr/share/nginx/html -COPY --from=build /build/docfx/wwwroot /usr/share/nginx/html +FROM --platform=$BUILDPLATFORM codebeltnet/docfx:2.78.3 AS build +WORKDIR /build/docfx +COPY . . +RUN docfx build + +FROM --platform=$TARGETPLATFORM nginx:${NGINX_VERSION} AS final +WORKDIR /usr/share/nginx/html +RUN rm -rf /usr/share/nginx/html/* +COPY --from=build /build/docfx/wwwroot/ /usr/share/nginx/html/ ENTRYPOINT ["nginx", "-g", "daemon off;"]Also applies to: 13-17
🧹 Nitpick comments (1)
CHANGELOG.md (1)
10-13
: 10.0.6 changelog entry — LGTM.Consider adding a brief bullet list of the headline package bumps (e.g., Cuemon.* 9.0.9, Microsoft.Extensions.* 9.0.9, TestHost 8.0.20/9.0.9) for quick diffability next time.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
.docfx/Dockerfile.docfx
(1 hunks).nuget/Codebelt.Extensions.Xunit.App/PackageReleaseNotes.txt
(1 hunks).nuget/Codebelt.Extensions.Xunit.Hosting.AspNetCore/PackageReleaseNotes.txt
(1 hunks).nuget/Codebelt.Extensions.Xunit.Hosting/PackageReleaseNotes.txt
(1 hunks).nuget/Codebelt.Extensions.Xunit/PackageReleaseNotes.txt
(1 hunks)CHANGELOG.md
(1 hunks)Directory.Packages.props
(2 hunks)testenvironments.json
(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-10-09T14:10:40.721Z
Learnt from: gimlichael
PR: codebeltnet/xunit#17
File: src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj:22-26
Timestamp: 2024-10-09T14:10:40.721Z
Learning: In the `src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj` file, only certain .NET 8 packages are available in version 8.0.1, while others remain at 8.0.0, so package versions may differ due to availability.
Applied to files:
CHANGELOG.md
Directory.Packages.props
.nuget/Codebelt.Extensions.Xunit.Hosting/PackageReleaseNotes.txt
.nuget/Codebelt.Extensions.Xunit.Hosting.AspNetCore/PackageReleaseNotes.txt
.nuget/Codebelt.Extensions.Xunit.App/PackageReleaseNotes.txt
.nuget/Codebelt.Extensions.Xunit/PackageReleaseNotes.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: call-test (windows-2022, Release) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug) / 🧪 Test
🔇 Additional comments (7)
.nuget/Codebelt.Extensions.Xunit/PackageReleaseNotes.txt (1)
1-6
: Release notes update — LGTM.Reads clearly; no API claims, only dependency hygiene.
.nuget/Codebelt.Extensions.Xunit.Hosting/PackageReleaseNotes.txt (1)
1-6
: Release notes update — LGTM.Consistency with CHANGELOG and other packages looks good.
.nuget/Codebelt.Extensions.Xunit.App/PackageReleaseNotes.txt (1)
1-6
: Release notes update — LGTM.Matches the service‑update intent.
.nuget/Codebelt.Extensions.Xunit.Hosting.AspNetCore/PackageReleaseNotes.txt (1)
1-6
: Release notes update — LGTM.Scope and availability lines align with supported TFMs.
testenvironments.json (1)
12-12
: Tag exists but arm64 not found — confirm multi‑arch before merging.Docker Hub shows gimlichael/ubuntu-testrunner:net8.0.414-9.0.305 with images: linux/amd64 and unknown/unknown. Ensure this tag publishes linux/arm64 (or a manifest list including arm64) and verify with
docker manifest inspect gimlichael/ubuntu-testrunner:net8.0.414-9.0.305
orskopeo inspect docker://gimlichael/ubuntu-testrunner:net8.0.414-9.0.305
.
Location: testenvironments.json:12.docfx/Dockerfile.docfx (1)
1-1
: Pin nginx base images by digest.Keep the readable tag but pin to a sha256 digest to prevent surprise base‑image changes. Update both FROM lines in .docfx/Dockerfile.docfx (line 3:
FROM --platform=$BUILDPLATFORM nginx:${NGINX_VERSION} AS base
; line 13:FROM nginx:${NGINX_VERSION} AS final
) tonginx:1.29.1-alpine@sha256:<digest>
(or pin per‑platform with--platform
). Run locally to pick the digest:docker buildx imagetools inspect nginx:1.29.1-alpine
and replace the FROMs accordingly.Directory.Packages.props (1)
7-10
: Validate NuGet patch levels and security advisories for the bumped packages.Net9 entries are 9.0.9; net8/netstandard2 Microsoft.AspNetCore.TestHost is 8.0.20. Sandbox verification failed (curl 404 / gh GraphQL errors) — validate latest 9.x/8.x patches and run an advisory scan for packages in Directory.Packages.props (lines 7–10, 26–33, 34–41).
This pull request is a service update focused on upgrading package dependencies across the project to their latest compatible versions. It also updates release notes and documentation to reflect these changes, and bumps the NGINX version in the Dockerfile.
Dependency Updates:
Directory.Packages.props
, includingCuemon.Core
,Cuemon.Extensions.AspNetCore
,Cuemon.Extensions.IO
,Microsoft.Bcl.AsyncInterfaces
, and variousMicrosoft.Extensions.*
packages for .NET 9 and .NET 8 target frameworks. [1] [2]Microsoft.AspNetCore.TestHost
package for .NET 8 and .NET Standard 2.0 targets.Release Notes and Documentation:
PackageReleaseNotes.txt
files to indicate dependency upgrades and availability for supported frameworks. [1] [2] [3] [4]CHANGELOG.md
describing this as a service update focused on package dependencies.Build and Test Environment:
.docfx/Dockerfile.docfx
from1.29.0-alpine
to1.29.1-alpine
.testenvironments.json
to usegimlichael/ubuntu-testrunner:net8.0.414-9.0.305
.Summary by CodeRabbit
Chores
Documentation