v10.y.z/bump-dependencies #37
Conversation
WalkthroughThis update refreshes dependencies and infrastructure components. It upgrades the nginx and docfx Docker base images, adds explicit multi-platform support in the Dockerfile, bumps several NuGet package versions in the project configuration, and updates the Docker image tag for the Ubuntu test environment. Changes
Possibly related PRs
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR bumps key dependencies, updates Docker configurations, and revises the test runner image to ensure compatibility with newer libraries and platforms.
- Updates NuGet package versions in Directory.Packages.props to patch versions.
- Upgrades Docker base and build images in .docfx/Dockerfile.docfx.
- Revises the Docker test runner image in testenvironments.json.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| testenvironments.json | Updated test runner image to mono-net8.0.409-9.0.300 |
| Directory.Packages.props | Bumped several NuGet package versions including Cuemon and xunit packages |
| .docfx/Dockerfile.docfx | Updated Docker base image and build image versions with platform support |
| docfx build | ||
|
|
||
| FROM base AS final | ||
| FROM nginx:1.27.5-alpine AS final |
There was a problem hiding this comment.
Consider adding '--platform=$BUILDPLATFORM' to the final stage to maintain consistency with the base stage and support multi-platform builds.
| FROM nginx:1.27.5-alpine AS final | |
| FROM --platform=$BUILDPLATFORM nginx:1.27.5-alpine AS final |
Copilot uses AI. Check for mistakes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.docfx/Dockerfile.docfx (1)
6-6: Use COPY instead of ADD for directories
According to Docker best practices,COPYis preferred overADDwhen you don’t need its extra features (tar auto-extraction, remote URLs).Apply this diff:
- ADD [".", "docfx"] + COPY . docfx🧰 Tools
🪛 Hadolint (2.12.0)
[error] 6-6: Use COPY instead of ADD for files and folders
(DL3020)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.docfx/Dockerfile.docfx(1 hunks)Directory.Packages.props(2 hunks)testenvironments.json(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
Directory.Packages.props (1)
Learnt from: gimlichael
PR: codebeltnet/xunit#17
File: src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj:22-26
Timestamp: 2024-10-09T14:10:40.721Z
Learning: In the `src/Codebelt.Extensions.Xunit.Hosting/Codebelt.Extensions.Xunit.Hosting.csproj` file, only certain .NET 8 packages are available in version 8.0.1, while others remain at 8.0.0, so package versions may differ due to availability.
🪛 Hadolint (2.12.0)
.docfx/Dockerfile.docfx
[error] 6-6: Use COPY instead of ADD for files and folders
(DL3020)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: call-test (windows-2022, Release) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release) / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
🔇 Additional comments (8)
.docfx/Dockerfile.docfx (3)
1-1: Approve multi-platform base image update
The addition of--platform=$BUILDPLATFORMwith the nginx image ensures multi-architecture builds are supported.
4-4: Approve DocFX build image bump
Updating the build image tocodebeltnet/docfx:2.78.3aligns with the upstream DocFX release.
11-11: Approve final stage image consistency
Switching the final stage to the samenginx:1.27.5-alpineensures consistency with the base stage and benefits from the security patch.Directory.Packages.props (4)
7-10: Approve Cuemon and AsyncInterfaces patch bumps
BumpingCuemon.*andMicrosoft.Bcl.AsyncInterfacesfrom 9.0.4 to 9.0.5 is a straightforward patch update. Ensure downstream projects are compatible, but no breaking changes are expected.
27-32: Approve .NET 9 Microsoft.Extensions and TestHost bumps
Updating allMicrosoft.Extensions.*andMicrosoft.AspNetCore.TestHostto 9.0.5 ensures consistency across the net9 target framework.
40-40: Approve .NET 8 TestHost patch bump
The bump from 8.0.15 to 8.0.16 forMicrosoft.AspNetCore.TestHostis a safe patch-level update.
23-23:✅ Verification successful
Verify xunit.runner.visualstudio 3.1.0 availability
The upgrade from 3.0.2 to 3.1.0 may include new features or fixes—let’s confirm the package exists and is compatible.
🏁 Script executed:
#!/bin/bash # Check that xunit.runner.visualstudio 3.1.0 is available on NuGet.org dotnet nuget list package xunit.runner.visualstudio --source nuget.org --include-prerelease --verbosity quiet | grep "3.1.0"Length of output: 221
🏁 Script executed:
#!/bin/bash # Verify xunit.runner.visualstudio 3.1.0 availability via NuGet V3 API curl -s https://api.nuget.org/v3-flatcontainer/xunit.runner.visualstudio/index.json | grep '"3.1.0"'Length of output: 114
xunit.runner.visualstudio 3.1.0 is available on NuGet.org
The NuGet V3 API confirms that version 3.1.0 exists and can be consumed—go ahead with the update.testenvironments.json (1)
12-12:❓ Verification inconclusive
Verify updated Docker test runner image
Ensure thatgimlichael/ubuntu-testrunner:mono-net8.0.409-9.0.300is published and contains the expected SDK/runtime.
🏁 Script executed:
#!/bin/bash # Check that the Docker image tag exists on Docker Hub curl -s https://registry.hub.docker.com/v2/repositories/gimlichael/ubuntu-testrunner/tags/mono-net8.0.409-9.0.300/ | jq .Length of output: 1536
Docker image tag verified
The taggimlichael/ubuntu-testrunner:mono-net8.0.409-9.0.300is published on Docker Hub.To confirm it contains the expected .NET 8.0.409 SDK and Mono 9.0.300 runtime, please run:
docker run --rm gimlichael/ubuntu-testrunner:mono-net8.0.409-9.0.300 dotnet --list-sdks docker run --rm gimlichael/ubuntu-testrunner:mono-net8.0.409-9.0.300 mono --versionEnsure the output lists SDK 8.0.409 and Mono 9.0.300.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 48 48
Lines 931 931
Branches 120 120
=======================================
Hits 859 859
Misses 62 62
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
1 participant
This pull request includes updates to dependencies, Docker configurations, and test environments to ensure compatibility with newer versions and improve stability. The most important changes include upgrading Docker base images, updating NuGet package versions, and modifying the Docker test runner image.
Dependency Updates:
Directory.Packages.propsto the latest patch versions forCuemon,Microsoft.Bcl.AsyncInterfaces,Microsoft.Extensions.*, andxunit.runner.visualstudio. These updates improve compatibility and address potential bug fixes. [1] [2]Docker Configuration Updates:
.docfx/Dockerfile.docfxtonginx:1.27.5-alpineand the build image tocodebeltnet/docfx:2.78.3. These changes ensure compatibility with the latest platform features and security patches.Test Environment Updates:
testenvironments.jsontogimlichael/ubuntu-testrunner:mono-net8.0.409-9.0.300, ensuring compatibility with updated frameworks and runtime versions.Summary by CodeRabbit