[WIP]Fix nightly upload nuget package order #439
Conversation
All the redundancy between the .nuspec file and the .csproj file (both express and implied) is now removed. With it, I fix a few bugs: 1. The generated nuspec file includes the developmentDependency tag that was in the project file but not the checked in file. 1. The package now applies to *all* projects regardless of their target framework (well, so long as they're .netstandard1.0 compatible) instead of all projects rejecting this package unless they targeted .NET Core 2.0 or higher. I also moved the .targets file into a folder structure within the project that resembles where it will appear in the package. This makes it more obvious that it belongs to the package when looking at the source code, and makes it easier to maintain the build/ folder in the package going forward because all files in it are included. Fixes coverlet-coverage#431
For a perfectly clean repo (git clean -fdx), `dotnet build` fails because some tests require that other projects have been built using build.proj first. This change adds the necessary build ordering instructions so that the build tasks are always built before the tests that need them, and the tests are always run against the *latest* source code being tested rather than the last version that happened to be built with build.proj.
MarcoRossignoli
changed the title
MarcoRossignoli
changed the title
MarcoRossignoli
force-pushed
the
fixnightly
branch
from
fbf1f3b to
6d0b645
Compare
|
@AArnott here #403 (comment) you said "moving your versioning to a major.minor.height pattern?" but I cannot have this behaviour, in this PR I fixed order issue and I like it we release 3 package with hash and height and after some usage tests I found ok the user experience, clear the order(last master first in vs dropdown) and simple way to link with master commit with hash. EDIT:
11 is the height @AArnott is this possible? |
MarcoRossignoli
changed the title
Replace checked in .nuspec file with generated one
…celinkbug [Bug fix]Fix "/p:UseSourceLink=true" bug
Fix `dotnet build` of a clean repo
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
It's up to you. But I'm a bit confused because later in your above comment it sounds like you're asking for exactly what I had prescribed:
Yes. I'm happy to help you do that.
That's not the right syntax. Instead, use |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Now regarding the |
|
Close and reopen I did a mess with rebase 😞 |
|
BTW @AArnott seem that works as expected now I'll open a new PR with where I'll publish directly with CI, we'll go on on that thread! |
@AArnott point me your doc when done! |
|
Will do. I hope to have it done by EOD. |
|
Oh ready for my breakfast 😄 |
|
OK, here is the first draft. I'd be interested in your feedback and questions before I merge this into master. |
|
Doc are very clear...open a draft if you want and I'll review also with some simple advice like newlines |
Fix nightly upload nuget package order
Now we've order i.e.
coverlet.msbuild.2.6.1-preview-0011-gfbf1f3beb8.nupkgcc: @tonerdo