Move live reload client code to new hot_reload_client.dart file #1732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samogot
changed the title
It is expected that client code will become complicated, so in separate dart file it would be easier to test and maintain.
samogot
force-pushed
the
create-hotreload-client
branch
from
13dfc7f to
f8b1efc
Compare
natebosch
reviewed
Aug 8, 2018
| location.reload(); | ||
| }; | ||
| }()); | ||
| requirejs(['packages/build_runner/src/server/hot_reload_client.dart']) |
There was a problem hiding this comment.
I'm not sure if we should be relying on requirejs here... is there any other way we can handle this?
| @@ -0,0 +1,3857 @@ | |||
| // Generated by dart2js (full emitter, strong), the Dart to JavaScript compiler version: 2.0.0-dev.69.4. | |||
There was a problem hiding this comment.
we should check if there are other flags we should be using. --minify, maybe --omit-implicit-checks
ideally we should get this code size down
jakemac53
reviewed
Aug 8, 2018
.gitignore
Outdated
| @@ -21,3 +21,6 @@ bazel-* | |||
| packages.bzl | |||
| BUILD | |||
| WORKSPACE | |||
|
|
|||
| # Deps of checked-in dart2js generated code | |||
| *.dart.js.deps | |||
There was a problem hiding this comment.
Lets be a bit more specific here, also see #1734 for the custom build script which we can update to also run on this new entrypoint.
samogot
force-pushed
the
create-hotreload-client
branch
from
b25e229 to
e8a2e98
Compare
jakemac53
approved these changes
Aug 9, 2018
samogot
added a commit
that referenced
this pull request
Aug 28, 2018
* Add assets digests handler (#1709) This entry point will be used for hot reloading, in order to initially retrieve digests of all assets, as build_runner might not know list of all of them, unlike client. * Emit useful information about build results (#1710) Instead of just 'update' emit json with updated build results and its digests * Move live reload client code to new hot_reload_client.dart file (#1732) It is expected that client code will become complicated, so in separate dart file it would be easier to test and maintain. * Implement basic hot reload (#1741) Reload any changed modules without any specific order, then reload main module and call main func to hopefully apply changes. Still need to get module dependency graph to reload in topological order and find correct ancessor chain where reloaded modules can be saved in closures. * Basic graph handling for hot reload (#1759) We still lack handling situations when graph is dynamically updated between reloads. * Add rough graph changes handling by full page reload (#1763) * Simplify module interface (#1764) * Change HMR API to work with several libraries bundled in one module (#1765) Fixes #1762 * Close Hot Reload listeners on exit (#1775) Closes #1774 * Refactor and improve HMR code (#1770) - Get rid of `roughLibraryKeyDecode` - use library path exposed from dart runtime now. - Get load modules from cache directly and throw if it isn't loaded instead of using require.js and hoping that module already loaded and no network request would be done. - Don't mess with `.ddc` extension in `build_runner` code - encapsulate all of it on build_web_compilers side. Fixes #1760 Fixes #1762 * Finalize hot-reloading feature (#1773) - Rename live-reload to hot-reload - Add debug logging about reloading - Add documentation - Version bump and changelog Fixes #1766 * Restore --live-reload option (#1778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is expected that client code will become complicated, so in separate
dart file it would be easier to test and maintain.