Add rough graph changes handling by full page reload #1763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
reviewed
Aug 14, 2018
| completer.complete(ModuleWrapper(module)))); | ||
| return completer.future; | ||
| } | ||
| Future<Module> Function(String) _wrapLoaderFunction( |
There was a problem hiding this comment.
Can you use a more descriptive name here? Something that indicates the purpose of the wrapping.
| var parentIds = _moduleParents(moduleId); | ||
| if (parentIds == null || parentIds.isEmpty) { | ||
| // Propagating from root should cause page reload | ||
| _reloadPage(); |
There was a problem hiding this comment.
Not for this PR but I wonder if we should add some debug level prints for when a hot reload is initiated?
jakemac53
reviewed
Aug 15, 2018
| } | ||
| } on DeferredLoadException catch (e) { |
There was a problem hiding this comment.
DeferredLoadException isn't really the correct type of exception here (even though it sounds sort of right). This is meant for deferred loaded Dart imports.
I would just create your own exception type.
| @@ -71,6 +71,13 @@ void main() { | |||
| verifyInOrder([methods.reloadModule('root'), methods.reloadPage()]); | |||
| }); | |||
|
|
|||
| test('reloadind error triggers page reload', () async { | |||
| @@ -305,6 +321,20 @@ final _requireJsConfig = ''' | |||
| (function() { | |||
| var oldOnError = requirejs.onError; | |||
| requirejs.onError = function(e) { | |||
| if (e.requireModules) { | |||
| // If error ocuired on loading dependencies, we need to invalidate ancessor too. | |||
| window.location.reload(); | ||
| } | ||
| } | ||
| \$dartLoader.modulesGraph.set(map.name, []); |
There was a problem hiding this comment.
should this all move into an else block? I don't think we need to clear it out and set it up again.
jakemac53
approved these changes
Aug 15, 2018
samogot
added a commit
that referenced
this pull request
Aug 28, 2018
* Add assets digests handler (#1709) This entry point will be used for hot reloading, in order to initially retrieve digests of all assets, as build_runner might not know list of all of them, unlike client. * Emit useful information about build results (#1710) Instead of just 'update' emit json with updated build results and its digests * Move live reload client code to new hot_reload_client.dart file (#1732) It is expected that client code will become complicated, so in separate dart file it would be easier to test and maintain. * Implement basic hot reload (#1741) Reload any changed modules without any specific order, then reload main module and call main func to hopefully apply changes. Still need to get module dependency graph to reload in topological order and find correct ancessor chain where reloaded modules can be saved in closures. * Basic graph handling for hot reload (#1759) We still lack handling situations when graph is dynamically updated between reloads. * Add rough graph changes handling by full page reload (#1763) * Simplify module interface (#1764) * Change HMR API to work with several libraries bundled in one module (#1765) Fixes #1762 * Close Hot Reload listeners on exit (#1775) Closes #1774 * Refactor and improve HMR code (#1770) - Get rid of `roughLibraryKeyDecode` - use library path exposed from dart runtime now. - Get load modules from cache directly and throw if it isn't loaded instead of using require.js and hoping that module already loaded and no network request would be done. - Don't mess with `.ddc` extension in `build_runner` code - encapsulate all of it on build_web_compilers side. Fixes #1760 Fixes #1762 * Finalize hot-reloading feature (#1773) - Rename live-reload to hot-reload - Add debug logging about reloading - Add documentation - Version bump and changelog Fixes #1766 * Restore --live-reload option (#1778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.