Hot reload #1786
Merged
Hot reload #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This entry point will be used for hot reloading, in order to initially retrieve digests of all assets, as build_runner might not know list of all of them, unlike client.
Instead of just 'update' emit json with updated build results and its digests
# Conflicts: # build_runner/lib/src/server/server.dart
Master merge in + enable Travis
It is expected that client code will become complicated, so in separate dart file it would be easier to test and maintain.
Reload any changed modules without any specific order, then reload main module and call main func to hopefully apply changes. Still need to get module dependency graph to reload in topological order and find correct ancessor chain where reloaded modules can be saved in closures.
We still lack handling situations when graph is dynamically updated between reloads.
- Get rid of `roughLibraryKeyDecode` - use library path exposed from dart runtime now. - Get load modules from cache directly and throw if it isn't loaded instead of using require.js and hoping that module already loaded and no network request would be done. - Don't mess with `.ddc` extension in `build_runner` code - encapsulate all of it on build_web_compilers side. Fixes #1760 Fixes #1762
- Rename live-reload to hot-reload - Add debug logging about reloading - Add documentation - Version bump and changelog Fixes #1766
jakemac53
reviewed
Aug 24, 2018
| var moduleValues = | ||
| List<HotReloadableLibrary>.from(_jsObjectValues(moduleObj)); | ||
| var moduleLibraries = moduleValues.map((x) => LibraryWrapper(x)); | ||
| var module = Module(Map.fromIterables(moduleKeys, moduleLibraries)); |
There was a problem hiding this comment.
nit: just return directly here
| var moduleObj = dartLoader.getModuleLibraries(moduleId); | ||
| if (moduleObj == null) { | ||
| throw HotReloadFailedException("Failed to get module '$moduleId'. " | ||
| "This error might appear if such module doesn't exist or isn't alredy loaded"); |
| (path) => dartLoader.urlToModuleId.get(currentOrigin + path), manager); | ||
|
|
||
| var webSocket = | ||
| WebSocket('ws://' + window.location.host, [_buildUpdatesProtocol]); |
There was a problem hiding this comment.
nit: use string interpolation 'ws://${window.location.host}'
build_web_compilers/pubspec.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: build_web_compilers | |||
| version: 0.4.3-dev | |||
There was a problem hiding this comment.
did 0.4.3 get released? We can roll this into it if not.
jakemac53
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
--hot-reloadcli option and appropriate functionality.