Master merge in #1731
Merged
Master merge in #1731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes up repeatedly that Builder authors are confused when they add print calls and can't see the messages because info lines get overwritten without `--verbose`, and `--verbose` adds a bunch of extra noise that drowns out the wanted messages. Since we expect Builder authors to rely on `log.info` for long term logging they want to keep at info and `print` to be used only for short term stuff it should be safe to up the level to warning.
Fixes #1702 - Adds a new node type `GlobAssetNode`, and a new interface (`NodeWithInputs`) for nodes that have some inputs and an invalidation state. - Results of the glob are cached on the node, and re-used across the same phase. - When using `findAssets`, the glob node gets as inputs all the available nodes, and is invalidated just like any other generated node when those inputs are invalidated. - On new/deleted sources we still need extra logic, but now it only iterates the glob nodes to check for globs which is more efficient than before in the case that a lot of nodes in the same phase performed the same globs.
# Conflicts: # build_runner/lib/src/server/server.dart
natebosch
approved these changes
Aug 7, 2018
samogot
force-pushed
the
master-merge-in
branch
from
d0e1805 to
065cf24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.