team lints: update to latest pkg:lints #359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update min SDK Format for latest SDK Prepare v3.5.2 for release
github-actions
bot
added
package:dart_flutter_team_lints
type-infra
|
I'd love to do |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR Health
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| dart_flutter_team_lints | Non-Breaking | 3.5.1 | 3.5.2 | 3.6.0 Got "3.5.2" expected >= "3.6.0" (non-breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Changelog Entry ✔️
| Package | Changed Files |
|---|
Changes to files need to be accounted for in their respective changelogs.
Coverage ⚠️
| File | Coverage |
|---|---|
| pkgs/dart_flutter_team_lints/tool/dedup.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbols |
|---|
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
devoncarew
reviewed
May 28, 2025
devoncarew
approved these changes
May 28, 2025
| @@ -26,7 +26,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| sdk: [dev] # TODO: add back in stable | |||
| sdk: [3.8, dev] | |||
There was a problem hiding this comment.
Perhaps:
Suggested change
| sdk: [3.8, dev] | |
| sdk: [3.8, stable, dev] |
There was a problem hiding this comment.
I mean, we could. I've never seen a bug that shows up in a middle build...
| @@ -38,6 +38,6 @@ jobs: | |||
| - run: dart analyze --fatal-infos | |||
|
|
|||
| - run: dart format --output=none --set-exit-if-changed . | |||
| if: ${{ matrix.sdk == 'stable' }} | |||
| if: ${{ matrix.sdk == 'dev' }} | |||
There was a problem hiding this comment.
What's wrong w/ 'stable' here (for verifying formatting)?
There was a problem hiding this comment.
Because developers generally use dev builds. Less likely to fight formatting deltas.
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 2, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/815d4ba..8cebaf0): 8cebaf0 2025-05-28 Kevin Moore team lints: update to latest pkg:lints (dart-lang/ecosystem#359) protobuf (https://github.com/dart-lang/protobuf/compare/d940c8d..c69077d): c69077d 2025-05-30 Devon Carew revert the change to not generate empty enum files (google/protobuf.dart#1016) 08e7410 2025-05-29 Devon Carew ignore unused_imports for json files (google/protobuf.dart#1013) efdabd7 2025-05-29 Devon Carew update how we calculate import prefixes (google/protobuf.dart#1012) 60dfaed 2025-05-28 Devon Carew rev package:protoc_plugin to 22.3.0 (google/protobuf.dart#1011) 86dfa6b 2025-05-27 Devon Carew move generated test code from out/ to test/gen/ (google/protobuf.dart#1009) test (https://github.com/dart-lang/test/compare/42a6d33..e2ddae9): e2ddae9f 2025-06-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/test#2506) tools (https://github.com/dart-lang/tools/compare/a0dda7e..04c6849): 04c68495 2025-06-01 dependabot[bot] Bump actions/setup-node from 3 to 4 in the github-actions group (dart-lang/tools#2106) webdev (https://github.com/dart-lang/webdev/compare/5dbb30e..64492b2): 64492b2d 2025-05-27 Nate Biggs Fix e2e 'evaluate' test to use new Closure toString format. (dart-lang/webdev#2624) webdriver (https://github.com/google/webdriver.dart/compare/f52afbf..b8f511d): b8f511d 2025-06-02 dependabot[bot] Bump nanasess/setup-chromedriver (google/webdriver.dart#329) Change-Id: If832327efab4615677528599ac51cecf4bb09fdf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432362 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update min SDK
Format for latest SDK
Prepare v3.5.2 for release