move generated test code from out/ to test/gen/ #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osa1
reviewed
May 27, 2025
| @@ -81,16 +81,7 @@ $(TEST_PROTO_LIBS): $(PLUGIN_SRC) $(TEST_PROTO_SRCS) | |||
| mkdir -p $(TEST_PROTO_DIR) | |||
|
|
|||
| protoc\ | |||
| --dart_out="disable_constructor_args:$(TEST_PROTO_DIR)"\ | |||
There was a problem hiding this comment.
So we no longer disable_constror_args? Is it not necessary?
Maybe we could rely on g3 tests for this. In g3 disable_constructor_args is the default as it causes binary size bloat.
There was a problem hiding this comment.
We're generating two versions of the test protos output for this one option - I'm just trying to dial things back a bit (we don't do this for other options). The disable_constructor_args option is tested in protoc_plugin/test/file_generator_test.dart and a bit in message_generator_test.dart.
Given the history in the changelog It sounds like having ctor args is the default externally, and not having them is the default internally.
osa1
approved these changes
May 27, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 2, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. ecosystem (https://github.com/dart-lang/ecosystem/compare/815d4ba..8cebaf0): 8cebaf0 2025-05-28 Kevin Moore team lints: update to latest pkg:lints (dart-lang/ecosystem#359) protobuf (https://github.com/dart-lang/protobuf/compare/d940c8d..c69077d): c69077d 2025-05-30 Devon Carew revert the change to not generate empty enum files (google/protobuf.dart#1016) 08e7410 2025-05-29 Devon Carew ignore unused_imports for json files (google/protobuf.dart#1013) efdabd7 2025-05-29 Devon Carew update how we calculate import prefixes (google/protobuf.dart#1012) 60dfaed 2025-05-28 Devon Carew rev package:protoc_plugin to 22.3.0 (google/protobuf.dart#1011) 86dfa6b 2025-05-27 Devon Carew move generated test code from out/ to test/gen/ (google/protobuf.dart#1009) test (https://github.com/dart-lang/test/compare/42a6d33..e2ddae9): e2ddae9f 2025-06-01 dependabot[bot] Bump the github-actions group with 2 updates (dart-lang/test#2506) tools (https://github.com/dart-lang/tools/compare/a0dda7e..04c6849): 04c68495 2025-06-01 dependabot[bot] Bump actions/setup-node from 3 to 4 in the github-actions group (dart-lang/tools#2106) webdev (https://github.com/dart-lang/webdev/compare/5dbb30e..64492b2): 64492b2d 2025-05-27 Nate Biggs Fix e2e 'evaluate' test to use new Closure toString format. (dart-lang/webdev#2624) webdriver (https://github.com/google/webdriver.dart/compare/f52afbf..b8f511d): b8f511d 2025-06-02 dependabot[bot] Bump nanasess/setup-chromedriver (google/webdriver.dart#329) Change-Id: If832327efab4615677528599ac51cecf4bb09fdf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432362 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mechanical refactors to the test dirs layout:
constructor_args_test.dart)out/totest/gen/We have half as much generated code for use by the tests now, and having it in
test/gen/is maybe a little more clear that it's used by the tests than having it inout/.Some future work might be to de-dup the protos in
test/protos/googleand instead reuse the ones inprotos/google.