ignore unused_imports for json files #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

devoncarew merged 3 commits into google:master from devoncarew:json_ignores

May 29, 2025

Collaborator

devoncarew commented May 28, 2025

ignore unused_imports for json files

devoncarew added 3 commits

May 28, 2025 10:27


          ignore unused_imports for json files

a1f4fde


          Merge branch 'master' into json_ignores

bc47528


          update the protoc_plugin changelog

a6fd2ae

devoncarew marked this pull request as ready for review

May 29, 2025 16:15

devoncarew requested a review from osa1

May 29, 2025 18:00

osa1 approved these changes

View reviewed changes

devoncarew merged commit 08e7410 into google:master

16 checks passed

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request


          [deps] rev ecosystem, protobuf, test, tools, webdev, webdriver

8711f55

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/815d4ba..8cebaf0):
  8cebaf0  2025-05-28  Kevin Moore  team lints: update to latest pkg:lints (dart-lang/ecosystem#359)

protobuf (https://github.com/dart-lang/protobuf/compare/d940c8d..c69077d):
  c69077d  2025-05-30  Devon Carew  revert the change to not generate empty enum files (google/protobuf.dart#1016)
  08e7410  2025-05-29  Devon Carew  ignore unused_imports for json files (google/protobuf.dart#1013)
  efdabd7  2025-05-29  Devon Carew  update how we calculate import prefixes (google/protobuf.dart#1012)
  60dfaed  2025-05-28  Devon Carew  rev package:protoc_plugin to 22.3.0 (google/protobuf.dart#1011)
  86dfa6b  2025-05-27  Devon Carew  move generated test code from out/ to test/gen/ (google/protobuf.dart#1009)

test (https://github.com/dart-lang/test/compare/42a6d33..e2ddae9):
  e2ddae9f  2025-06-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/test#2506)

tools (https://github.com/dart-lang/tools/compare/a0dda7e..04c6849):
  04c68495  2025-06-01  dependabot[bot]  Bump actions/setup-node from 3 to 4 in the github-actions group (dart-lang/tools#2106)

webdev (https://github.com/dart-lang/webdev/compare/5dbb30e..64492b2):
  64492b2d  2025-05-27  Nate Biggs  Fix e2e 'evaluate' test to use new Closure toString format. (dart-lang/webdev#2624)

webdriver (https://github.com/google/webdriver.dart/compare/f52afbf..b8f511d):
  b8f511d  2025-06-02  dependabot[bot]  Bump nanasess/setup-chromedriver (google/webdriver.dart#329)

Change-Id: If832327efab4615677528599ac51cecf4bb09fdf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432362
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet