Parser creates same nodes for catch (e) {} and catch (var e) {} #1602
Labels
Comments
|
Removed Area-Frog label. |
|
Changed the title to: "Parser creates same nodes for catch (e) {} and catch (var e) {}". |
|
It is now the last version -- catch (var e) -- that is illegal. Added this to the Later milestone. |
|
Removed this from the Later milestone. |
|
Added this to the M2 milestone. |
|
Removed Priority-Medium label. |
|
Removed this from the M2 milestone. |
|
Added TriageForM5 label. |
|
We've fixed this by implementing the new try-on-catch syntax. Removed TriageForM5 label. |
copybara-service bot
pushed a commit
that referenced
this issue
Dec 18, 2024
This is a minor change with just bug fixes: * Handle trailing commas in for-loop updaters (#1354). * Format `||` patterns like fallthrough cases in switch expressions (#1602). * Handle comments and metadata before variables more gracefully (#1604). * Ensure comment formatting is idempotent (#1606). * Better indentation of leading comments on property accesses in binary operator operands (#1611). * Don't crash on doc comments in local variable declarations (#1621). This won't affect much code, but it does change the formatting in some cases. Change-Id: I2d52fee92aecbc24315e4f1a89360af85ec85942 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401482 Auto-Submit: Bob Nystrom <[email protected]> Commit-Queue: Alexander Thomas <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by [email protected]
We need to differentiate between the two because the first is not valid.
The text was updated successfully, but these errors were encountered: