Skip to content

Process fails to execute at the end of test.dart #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
efortuna opened this issue Feb 10, 2012 · 2 comments
Closed

Process fails to execute at the end of test.dart #1611

efortuna opened this issue Feb 10, 2012 · 2 comments
Assignees
@whesse
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@efortuna
Copy link
Contributor

I've added a call spawning a new process near the end of test.dart. However, it doesn't execute. The same code placed in a stand-alone dart file executes correctly. (Unfortunately I haven't been able to produce a smaller test case)

I am working on forcing all browsers to close at the end of test.dart. I have attached the patch for this code that causes the bug, or you can look at the CL here: https://chromiumcodereview.appspot.com/9369051/ (relevant code in killZombieBrowsers function in test_suite.dart).

Although the print statement is executed right above the new Process call (line 602 test_suite.dart, it would seem that the command is not executed, nor is any error message printed. I've tested this in Windows and Mac, and they both fail this way.

Attachment:
ProcessPatch.diff (6.21 KB)
@whesse
Copy link
Contributor

whesse commented Feb 10, 2012

progress.allDone(), called from ProcessQueue._checkDone(), actively kills the test.dart script, by calling exit().
So if you register anything else to take place, asynchronously, then you have to
move the progress.allDone() to a handler that executes after your new tasks have completed, as with the delete.exitHandler a few lines below.

Set owner to @whesse.
Removed Type-Defect, Area-IO labels.
Added Type-Other, Area-Test, Done labels.

@DartBot
Copy link

DartBot commented Apr 7, 2013

This comment was originally written by [email protected]

Removed Type-Other label.
Added Type-Defect label.

@efortuna efortuna added Priority-Medium area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Apr 7, 2013
copybara-service bot pushed a commit that referenced this issue Dec 18, 2024
@munificent
Roll dart_style 3.0.1 into the SDK.
04530d5 
This is a minor change with just bug fixes:

* Handle trailing commas in for-loop updaters (#1354).
* Format `||` patterns like fallthrough cases in switch expressions (#1602).
* Handle comments and metadata before variables more gracefully (#1604).
* Ensure comment formatting is idempotent (#1606).
* Better indentation of leading comments on property accesses in binary operator
  operands (#1611).
* Don't crash on doc comments in local variable declarations (#1621).

This won't affect much code, but it does change the formatting in some cases.

Change-Id: I2d52fee92aecbc24315e4f1a89360af85ec85942
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401482
Auto-Submit: Bob Nystrom <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@efortuna @whesse @DartBot @mit-mit