document DOMContentLoaded doesn't work in dart:html #619
Assignees
Comments
|
This comment was originally written by [email protected] Issue #791 has been merged into this issue. |
|
This should be straightforward to fix. Change all event listeners on Document to listen on Document instead of the HTMLHtmlElement like they do now. Set owner to @nex3. |
|
Keep in mind that dart code will normally execute after DOMContentLoaded. Common usage is likely to be accidental. |
|
r3379 attaches all Document events to Document rather than HTMLElement. It doesn't address the other issues with DOMContentLoaded, though, since those are much broader. Added Fixed label. |
copybara-service bot
pushed a commit
that referenced
this issue
Jun 15, 2022
…ions) https://dart.googlesource.com/protobuf/+log/408f69b98b2d..3105588b8e51 2022-06-15 [email protected] Remove unused function 2022-06-15 [email protected] Simplify PbList implementation, fix freezing (#626) 2022-06-15 [email protected] Remove frozen message modification handling (#643) 2022-06-15 [email protected] Bump version number for development, add changelog entry for #644 2022-06-15 [email protected] Remove ReadonlyMessageMixin (#644) 2022-06-15 [email protected] Release protobuf-2.1.0, protoc_plugin-20.0.1 (#677) 2022-06-14 [email protected] Specify `GeneratedMessage operator==` argument type (#675) 2022-06-14 [email protected] Add changes since the last protobuf release to CHANGELOG (#619) 2022-06-10 [email protected] Tweak consts.dart docs (#674) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-protobuf-dart-sdk Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dart Protobuf Support: https://github.com/dart-lang/protobuf/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: If0f2beb1f63ef9a7527abaa116d883ef0fd4b6c9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248620 Commit-Queue: Nate Bosch <[email protected]> Reviewed-by: Nate Bosch <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by [email protected]
document.on.contentLoaded.add doesn't work when using dart:html, because the event listener is attached to the HTMLElement rather than the document element.
Actually, possibly we should consider removing this method from document events, because it is redundant with window.on.contentLoaded (which does currently work).
The text was updated successfully, but these errors were encountered: