Searchbox type queries should use working copies #674
Assignees
Labels
closed-invalid
Closed as we don't believe the reported issue is generally actionable
P3
A lower priority bug or feature request
type-enhancement
A request for a change that isn't a bug
Milestone
Comments
|
Added this to the Later milestone. |
|
The working copy story has gone the way of the Dodo. And so goes this bug too! Added Invalid label. |
pq
added
Type-Enhancement
P3
kevmoo
added
type-enhancement
copybara-service bot
pushed a commit
that referenced
this issue
Jun 15, 2022
…ions) https://dart.googlesource.com/protobuf/+log/408f69b98b2d..3105588b8e51 2022-06-15 [email protected] Remove unused function 2022-06-15 [email protected] Simplify PbList implementation, fix freezing (#626) 2022-06-15 [email protected] Remove frozen message modification handling (#643) 2022-06-15 [email protected] Bump version number for development, add changelog entry for #644 2022-06-15 [email protected] Remove ReadonlyMessageMixin (#644) 2022-06-15 [email protected] Release protobuf-2.1.0, protoc_plugin-20.0.1 (#677) 2022-06-14 [email protected] Specify `GeneratedMessage operator==` argument type (#675) 2022-06-14 [email protected] Add changes since the last protobuf release to CHANGELOG (#619) 2022-06-10 [email protected] Tweak consts.dart docs (#674) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-protobuf-dart-sdk Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dart Protobuf Support: https://github.com/dart-lang/protobuf/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: [email protected] Change-Id: If0f2beb1f63ef9a7527abaa116d883ef0fd4b6c9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248620 Commit-Queue: Nate Bosch <[email protected]> Reviewed-by: Nate Bosch <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In an ideal world, the omnibox should know about working copies. Specifically, to provide the most accurate (and complete) type query results, it's TypeProvider should be updated to pass a WorkingCopyOwner into its query to the SearchEngine.
The text was updated successfully, but these errors were encountered: