[Xamarin.Android.Build.Tasks] Correctly set build tools version in CheckSignApk test #966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eckSignApk test The test failed locally for me with: ``` /Users/alexander/dev/xamarin-android/bin/Debug/lib/xamarin.android/xbuild/Xamarin/Android/Xamarin.Android.Common.targets: error : '/Users/alexander/Library/Developer/Xamarin/android-sdk-macosx/build-tools/23.0.0/apksigner' does not exist. You need to install android-sdk build-tools 26.0.1 or above. ``` which is weird since it's looking into the 23.0.0 build tools which doesn't have apksigner even though the test specifies build tools 26.0.1. Turns out the test had a typo, it used AndroidBuildToolsVersion instead of AndroidSdkBuildToolsVersion so it fell back to 23.0.0 :)
dellis1972
approved these changes
Oct 24, 2017
Redth
pushed a commit
to Redth/xamarin-android
that referenced
this pull request
Oct 30, 2017
…eckSignApk test (dotnet#966) The test failed locally for me with: ``` …/xamarin-android/bin/Debug/lib/xamarin.android/xbuild/Xamarin/Android/Xamarin.Android.Common.targets: error : '…/android-sdk-macosx/build-tools/23.0.0/apksigner' does not exist. You need to install android-sdk build-tools 26.0.1 or above. ``` which is weird since it's looking into the 23.0.0 build tools which doesn't have apksigner even though the test specifies build tools 26.0.1. Turns out the test had a typo, it used `AndroidBuildToolsVersion` instead of `AndroidSdkBuildToolsVersion` so it fell back to 23.0.0 :)
dellis1972
added a commit
to dellis1972/xamarin-android
that referenced
this pull request
Apr 16, 2019
As part of a move to unify our unit tests into the main repo this PR brings in all the InstantRun tests. They are protected bbehind a `CommercialBuildAvailable` check which will only be `true` if the commercial parts are available. The commercial tests are also flagged with a nunit category attribute of `Commercial` just in case we decide to filter in the future. This PR also makes some changes to the folder structure. ALL `Task` based tests (i.e ones that test just a Task using the MockBbuildEngine) have been moved into the `Tasks` folder. We already have a few tests in that folder, this make sure they are all in one place. the `*.OSS.cs` partial class files have been renamed to `*.TestCaseSource.cs`. They also handle the tests for BOTH open source and commercial builds. As a result they will not longer be needed in the commercial repo. They were also moved into the shared project. This change will probably cause commercial build failures until PR dotnet#966 is merged on the commercial side.
dellis1972
added a commit
to dellis1972/xamarin-android
that referenced
this pull request
Apr 16, 2019
As part of a move to unify our unit tests into the main repo this PR brings in all the InstantRun tests. They are protected bbehind a `CommercialBuildAvailable` check which will only be `true` if the commercial parts are available. The commercial tests are also flagged with a nunit category attribute of `Commercial` just in case we decide to filter in the future. This PR also makes some changes to the folder structure. ALL `Task` based tests (i.e ones that test just a Task using the MockBbuildEngine) have been moved into the `Tasks` folder. We already have a few tests in that folder, this make sure they are all in one place. the `*.OSS.cs` partial class files have been renamed to `*.TestCaseSource.cs`. They also handle the tests for BOTH open source and commercial builds. As a result they will not longer be needed in the commercial repo. They were also moved into the shared project. This change will probably cause commercial build failures until PR dotnet#966 is merged on the commercial side.
jonpryor
pushed a commit
that referenced
this pull request
Apr 16, 2019
As part of a move to unify our unit tests into the main repo this PR
brings in all the InstantRun tests. They are protected behind a
`CommercialBuildAvailable` check which will only be `true` if the
commercial parts are available. The commercial tests are also flagged
with a nunit `[Category("Commercial")]` just in case we decide to
filter in the future.
This PR also makes some changes to the folder structure. ALL `Task`
based tests (i.e ones that test just a `Task` using the
`MockBbuildEngine`) have been moved into the `Tasks` folder.
We already have a few tests in that folder, this make sure they are
all in one place.
The `*.OSS.cs` partial class files have been renamed to
`*.TestCaseSource.cs`. They also handle the tests for BOTH open
source and commercial builds. As a result they will not longer be
needed in the commercial repo. They were also moved into the shared
project. This change will probably cause commercial build failures
until PR #966 is merged on the commercial side.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 19, 2022
Fixes: dotnet/java-interop#967 Changes: dotnet/java-interop@05bfece...05eddd9 * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (dotnet#970) * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (dotnet#968) * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (dotnet#966) * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (dotnet#965)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 19, 2022
Fixes: dotnet/java-interop#967 Changes: dotnet/java-interop@05bfece...05eddd9 * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (dotnet#970) * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (dotnet#968) * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (dotnet#966) * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (dotnet#965)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 21, 2022
Fixes: dotnet/java-interop#967 Changes: dotnet/java-interop@05bfece...2a882d2 * dotnet/java-interop@2a882d2d: [generator] Fix xamarin-android/src/Mono.Android build (dotnet#972) * dotnet/java-interop@968e0f5f: [Directory.Build.props] Set dummy $(PackageVersion) to appease NuGet (dotnet#971) * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (dotnet#970) * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (dotnet#968) * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (dotnet#966) * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (dotnet#965)
jonpryor
added a commit
that referenced
this pull request
Apr 21, 2022
Fixes: dotnet/java-interop#967 Changes: dotnet/java-interop@05bfece...2a882d2 * dotnet/java-interop@2a882d2d: [generator] Fix xamarin-android/src/Mono.Android build (#972) * dotnet/java-interop@968e0f5f: [Directory.Build.props] Set dummy $(PackageVersion) to appease NuGet (#971) * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (#970) * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (#968) * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (#966) * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (#965)
jonathanpeppers
pushed a commit
that referenced
this pull request
Apr 25, 2022
Fixes: dotnet/java-interop#967 Changes: dotnet/java-interop@05bfece...2a882d2 * dotnet/java-interop@2a882d2d: [generator] Fix xamarin-android/src/Mono.Android build (#972) * dotnet/java-interop@968e0f5f: [Directory.Build.props] Set dummy $(PackageVersion) to appease NuGet (#971) * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (#970) * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (#968) * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (#966) * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (#965)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test failed locally for me with:
which is weird since it's looking into the 23.0.0 build tools which doesn't have apksigner even though the test specifies build tools 26.0.1.
Turns out the test had a typo, it used AndroidBuildToolsVersion instead of AndroidSdkBuildToolsVersion so it fell back to 23.0.0 :)