Skip to content

[xabuild] print config file to console on error #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

jonathanpeppers
Copy link
Member

There are cases in which diagnostic MSBuild output is not including
important information such as $(MSBuildExtensionsPath).

To help debug situations like this, if MSBuildApp.Main returns a
non-zero exit code, we can print the contents of xabuild.exe's config
file to the console.

There are cases in which diagnostic MSBuild output is not including
important information such as `$(MSBuildExtensionsPath)`.

To help debug situations like this, if `MSBuildApp.Main` returns a
non-zero exit code, we can print the contents of xabuild.exe's config
file to the console.
@dnfclas
Copy link

dnfclas commented Oct 24, 2017

@jonathanpeppers,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@jonpryor jonpryor merged commit 5a9ba9f into dotnet:master Oct 24, 2017
@jonathanpeppers jonathanpeppers deleted the xabuild-config-failure branch October 24, 2017 19:26
Redth pushed a commit to Redth/xamarin-android that referenced this pull request Oct 30, 2017
There are cases in which diagnostic MSBuild output is not including
important information such as `$(MSBuildExtensionsPath)`.

To help debug situations like this, if `MSBuildApp.Main` returns a
non-zero exit code, we can print the contents of xabuild.exe's config
file to the console.
jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Apr 21, 2022
Fixes: dotnet/java-interop#967

Changes: dotnet/java-interop@05bfece...2a882d2

  * dotnet/java-interop@2a882d2d: [generator] Fix xamarin-android/src/Mono.Android build (dotnet#972)
  * dotnet/java-interop@968e0f5f: [Directory.Build.props] Set dummy $(PackageVersion) to appease NuGet (dotnet#971)
  * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (dotnet#970)
  * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (dotnet#968)
  * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (dotnet#966)
  * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (dotnet#965)
jonpryor added a commit that referenced this pull request Apr 21, 2022
Fixes: dotnet/java-interop#967

Changes: dotnet/java-interop@05bfece...2a882d2

  * dotnet/java-interop@2a882d2d: [generator] Fix xamarin-android/src/Mono.Android build (#972)
  * dotnet/java-interop@968e0f5f: [Directory.Build.props] Set dummy $(PackageVersion) to appease NuGet (#971)
  * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (#970)
  * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (#968)
  * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (#966)
  * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (#965)
jonathanpeppers pushed a commit that referenced this pull request Apr 25, 2022
Fixes: dotnet/java-interop#967

Changes: dotnet/java-interop@05bfece...2a882d2

  * dotnet/java-interop@2a882d2d: [generator] Fix xamarin-android/src/Mono.Android build (#972)
  * dotnet/java-interop@968e0f5f: [Directory.Build.props] Set dummy $(PackageVersion) to appease NuGet (#971)
  * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (#970)
  * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (#968)
  * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (#966)
  * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (#965)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants