[Xamarin.Android.Build.Tasks] Fix Type in the Xamarin.Android.Windows.targets #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….targets Commit 286b9c2 added extra item to the IncrementalClean ItemGroups. But one of them omited the `$`. This commit fixes that issue.
Redth
pushed a commit
to Redth/xamarin-android
that referenced
this pull request
Oct 30, 2017
…dotnet#970) Commit 286b9c2 added extra item to `@(_FilesToRegister)` as part of the `IncrementalClean` target. Unfortunately, one of the values omitted the `$`, resulting in an "invalid" property name reference. This commit fixes that issue.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 19, 2022
Fixes: dotnet/java-interop#967 Changes: dotnet/java-interop@05bfece...05eddd9 * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (dotnet#970) * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (dotnet#968) * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (dotnet#966) * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (dotnet#965)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 19, 2022
Fixes: dotnet/java-interop#967 Changes: dotnet/java-interop@05bfece...05eddd9 * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (dotnet#970) * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (dotnet#968) * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (dotnet#966) * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (dotnet#965)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 21, 2022
Fixes: dotnet/java-interop#967 Changes: dotnet/java-interop@05bfece...2a882d2 * dotnet/java-interop@2a882d2d: [generator] Fix xamarin-android/src/Mono.Android build (dotnet#972) * dotnet/java-interop@968e0f5f: [Directory.Build.props] Set dummy $(PackageVersion) to appease NuGet (dotnet#971) * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (dotnet#970) * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (dotnet#968) * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (dotnet#966) * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (dotnet#965)
jonpryor
added a commit
that referenced
this pull request
Apr 21, 2022
Fixes: dotnet/java-interop#967 Changes: dotnet/java-interop@05bfece...2a882d2 * dotnet/java-interop@2a882d2d: [generator] Fix xamarin-android/src/Mono.Android build (#972) * dotnet/java-interop@968e0f5f: [Directory.Build.props] Set dummy $(PackageVersion) to appease NuGet (#971) * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (#970) * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (#968) * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (#966) * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (#965)
jonathanpeppers
pushed a commit
that referenced
this pull request
Apr 25, 2022
Fixes: dotnet/java-interop#967 Changes: dotnet/java-interop@05bfece...2a882d2 * dotnet/java-interop@2a882d2d: [generator] Fix xamarin-android/src/Mono.Android build (#972) * dotnet/java-interop@968e0f5f: [Directory.Build.props] Set dummy $(PackageVersion) to appease NuGet (#971) * dotnet/java-interop@05eddd9a: [generator] Add string cast to prevent CS1503 (#970) * dotnet/java-interop@37cff251: [Java.Base, generator] Bind all of package java.io (#968) * dotnet/java-interop@a65d6fb4: [Java.Base, generator] Bind all of package java.lang (#966) * dotnet/java-interop@ed9c2abf: [Java.Interop-MonoAndroid] Set Version after Directory.Build.props (#965)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 286b9c2 added extra items to the IncrementalClean ItemGroups.
But one of them omited the
$. This commit fixes that issue.