Skip to content

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Nov 27, 2018

Initial PR for discussion, now that things mostly work on windows (88/92) passing:
UserSecrets has one test that can't find soln root and might just need to be reworked
Logging.Analyzer.Tests is very busted and needs further investigation why

build.cmd /t:Helix /p:HelixAccessToken=<PAT>

Example run results: https://mc.dot.net/#/user/HaoK/pr~2Faspnet~2Fextensions/ci/20181127.124408

Overview:

  • Single helix job
  • One work item per test project + framework permutation (i.e. Primitives.Test.csproj / net461)
  • different runtest.cmd for net461 (uses xunit-console in payload) / netcoreapp (downloads sdk for dotnet vstest)

TODOs:

  • Only targets windows queue (need to add logic to the test command to run on mac/linux)
  • Hardcodes sdk version to 2.1.500 for the helix jobs (which appears to be already installed for some of the work items, machines getting reused?)
  • Fix reporting (unit test summary got lost recently)

aspnetci and others added 30 commits October 7, 2018 19:14
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
[auto-updated: dependencies]
IHealthCheckPublisher allows you to configure and run health checks
regularly inside an application, and push the notifications elsewhere.

All publishers are part of a single queue with a configurable period and
timeout.
…master

[automated] Merge branch 'release/2.2' => 'master'
…master

[automated] Merge branch 'release/2.2' => 'master'
…master

[automated] Merge branch 'release/2.2' => 'master'
…master

[automated] Merge branch 'release/2.2' => 'master'
Nate McMaster and others added 24 commits December 10, 2018 16:46
Specifically:
* Don't let current thread continue until file system change is visible
* Retry when waiting for notifications
Add arcade eng

Delete stuff

Try create xunit

Test stuff

Update helix latest

Working tests

Revert "Delete stuff"

This reverts commit 81e9066.

Cleanup

Remove eng common stuff from helix

Cleanup

Update test/vstest/runtests.cmd

Co-Authored-By: HaoK <[email protected]>

Update test/vstest/runtests.cmd

Co-Authored-By: HaoK <[email protected]>

Update test/helix.proj

Co-Authored-By: HaoK <[email protected]>

Update Directory.Build.targets

Co-Authored-By: HaoK <[email protected]>

Update test/helix.proj

Co-Authored-By: HaoK <[email protected]>

Revert "Revert "Delete stuff""

This reverts commit a03d3dc.

Working stuff

Revert "Revert "Revert "Delete stuff"""

This reverts commit 35295d26ff11fd2177cd7db01191ba8d60936630.

Delete dotnet-install.ps1

Use $(NETCoreSdkVersion)

Revert "Use $(NETCoreSdkVersion)"

This reverts commit 8a52f64.

Update Directory.Build.targets

Update test/vstest/runtests.sh

Co-Authored-By: HaoK <[email protected]>

Update helix.proj
@HaoK
Copy link
Member Author

HaoK commented Dec 11, 2018

I messed up this PR, replaced by #628

@HaoK HaoK closed this Dec 11, 2018
@natemcmaster natemcmaster deleted the haok/helix21 branch May 3, 2019 23:49
@ghost ghost locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.