Skip to content

[iOS] Make sure always call decisionHandler even if no handler #18934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2023
Merged

[iOS] Make sure always call decisionHandler even if no handler #18934

merged 1 commit into from
Nov 22, 2023

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Nov 21, 2023 •
edited
Loading

Description of Change

When running DeviceTests on 15.4 to 14.5 we got some random failures like:

Objective-C exception thrown.  Name: NSInternalInconsistencyException Reason: Completion handler passed to -[Microsoft_Maui_Platform_MauiWebViewNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:] was not called

This makes sure we always call the decisionHandler

Fixes #18749

@rmarinho rmarinho requested a review from a team as a code owner November 21, 2023 17:14
@rmarinho rmarinho added area-testing Unit tests, device tests testing-flakiness labels Nov 21, 2023
@rmarinho rmarinho requested a review from PureWeen November 21, 2023 17:15
@PureWeen PureWeen enabled auto-merge (squash) November 21, 2023 19:12
@PureWeen PureWeen merged commit b8f99f4 into main Nov 22, 2023
@PureWeen PureWeen deleted the fix-DecidePolicy-ios branch November 22, 2023 12:27
This was referenced Nov 23, 2023
Open
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
@samhouts samhouts added the fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@hartez hartez Awaiting requested review from hartez hartez is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-testing Unit tests, device tests fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! platform/ios testing-flakiness
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Testing] Failing tests on iOS 14.5 - webView:decidePolicyForNavigationAction:decisionHandler:] was not called
3 participants
@rmarinho @PureWeen @samhouts