Skip to content

Adds cat-h values #5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 11, 2025
Merged

Adds cat-h values #5096

merged 5 commits into from
Aug 11, 2025

Conversation

kosabogi
Copy link
Contributor

@kosabogi kosabogi commented Aug 8, 2025

This PR adds missing -h values for 5 CAT APIs. These values were not present in the old docs and were still missing here. This work continues from #4345.

Changes in this PR

/cat/aliases
/cat/allocation
/cat/component_templates
/cat/count
/cat/fielddata

Remaining CAT APIs will be updated in separate PRs (about 5 per PR) for easier review.

Related issue: https://github.com/elastic/docs-content-internal/issues/73

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@kosabogi kosabogi requested a review from szabosteve August 11, 2025 08:32
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosabogi kosabogi merged commit 68ae2c1 into main Aug 11, 2025
8 checks passed
@kosabogi kosabogi deleted the cat-aliases branch August 11, 2025 09:28
Copy link
Contributor

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5096-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 68ae2c15382b796ea853a15aae05216e2e36e07e
# Push it to GitHub
git push --set-upstream origin backport-5096-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5096-to-8.19.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-5096-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 68ae2c15382b796ea853a15aae05216e2e36e07e
# Push it to GitHub
git push --set-upstream origin backport-5096-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-5096-to-8.18.

github-actions bot pushed a commit that referenced this pull request Aug 11, 2025
* Adds cat-h values

* Fixes typo

* Clean up CatBase.ts quotation mark usage

(cherry picked from commit 68ae2c1)
github-actions bot pushed a commit that referenced this pull request Aug 11, 2025
* Adds cat-h values

* Fixes typo

* Clean up CatBase.ts quotation mark usage

(cherry picked from commit 68ae2c1)
pquentin added a commit that referenced this pull request Aug 12, 2025
* Adds cat-h values

* Fixes typo

* Clean up CatBase.ts quotation mark usage

(cherry picked from commit 68ae2c1)

Co-authored-by: kosabogi <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Aug 12, 2025
* Adds cat-h values

* Fixes typo

* Clean up CatBase.ts quotation mark usage

(cherry picked from commit 68ae2c1)

Co-authored-by: kosabogi <[email protected]>
Co-authored-by: Quentin Pradet <[email protected]>
szybia added a commit that referenced this pull request Aug 12, 2025
* origin/main:
  [DOCS] Fix typos in the shared overlays file (#5124)
  Update specification output
  Remove unused EIS types (#5107)
  No native utility types validation lint (#4567)
  Document reindexing failures (#5031)
  Add dangling types to validation-errors.json (#5106)
  Update specification output
  Change `KeyedPercentiles` value type from `long` to `double` (#5108)
  [DOCS]: Add descriptions to API tags (#5098)
  Bump form-data and @redocly/cli in /docs/examples (#5074)
  Update specification output
  Adds cat-h values (#5096)
  Bump @eslint/plugin-kit from 0.3.3 to 0.3.4 in /specification (#5053)
  Update specification output
  [DOCS] Adds Ruby bulk helper to BulkRequest documentation (#5057)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants