Skip to content

Add dangling types to validation-errors.json #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025
Merged

Add dangling types to validation-errors.json #5106

merged 2 commits into from
Aug 11, 2025

Conversation

pquentin
Copy link
Member

Leaving an unused type in the specification is a bug and should never happen.

@pquentin pquentin requested a review from a team as a code owner August 11, 2025 12:12
@pquentin pquentin requested review from l-trotta and swallez and removed request for a team August 11, 2025 12:13
Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit de65a4b into main Aug 11, 2025
10 checks passed
@pquentin pquentin deleted the dangling-types branch August 11, 2025 15:27
Copy link
Contributor

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-5106-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 de65a4b759164ce6b1c637aac604d3c5dfc2038a
# Push it to GitHub
git push --set-upstream origin backport-5106-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-5106-to-8.19.

Copy link
Contributor

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.18 8.18
# Navigate to the new working tree
cd .worktrees/backport-8.18
# Create a new branch
git switch --create backport-5106-to-8.18
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 de65a4b759164ce6b1c637aac604d3c5dfc2038a
# Push it to GitHub
git push --set-upstream origin backport-5106-to-8.18
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-5106-to-8.18.

github-actions bot pushed a commit that referenced this pull request Aug 11, 2025
* Add dangling types to validation-errors.json

* Generate validation-errors.json

(cherry picked from commit de65a4b)
github-actions bot pushed a commit that referenced this pull request Aug 11, 2025
* Add dangling types to validation-errors.json

* Generate validation-errors.json

(cherry picked from commit de65a4b)
pquentin added a commit that referenced this pull request Aug 11, 2025
* Add dangling types to validation-errors.json

* Generate validation-errors.json

(cherry picked from commit de65a4b)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Aug 12, 2025
* Add dangling types to validation-errors.json

* Generate validation-errors.json

(cherry picked from commit de65a4b)

Co-authored-by: Quentin Pradet <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 12, 2025
* Add dangling types to validation-errors.json

* Generate validation-errors.json

(cherry picked from commit de65a4b)
github-actions bot pushed a commit that referenced this pull request Aug 12, 2025
* Add dangling types to validation-errors.json

* Generate validation-errors.json

(cherry picked from commit de65a4b)
pquentin added a commit that referenced this pull request Aug 12, 2025
* Add dangling types to validation-errors.json

* Generate validation-errors.json

(cherry picked from commit de65a4b)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Aug 12, 2025
* Add dangling types to validation-errors.json

* Generate validation-errors.json

(cherry picked from commit de65a4b)

Co-authored-by: Quentin Pradet <[email protected]>
szybia added a commit that referenced this pull request Aug 12, 2025
* origin/main:
  [DOCS] Fix typos in the shared overlays file (#5124)
  Update specification output
  Remove unused EIS types (#5107)
  No native utility types validation lint (#4567)
  Document reindexing failures (#5031)
  Add dangling types to validation-errors.json (#5106)
  Update specification output
  Change `KeyedPercentiles` value type from `long` to `double` (#5108)
  [DOCS]: Add descriptions to API tags (#5098)
  Bump form-data and @redocly/cli in /docs/examples (#5074)
  Update specification output
  Adds cat-h values (#5096)
  Bump @eslint/plugin-kit from 0.3.3 to 0.3.4 in /specification (#5053)
  Update specification output
  [DOCS] Adds Ruby bulk helper to BulkRequest documentation (#5057)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants